Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Apollo secret #1533

Merged
merged 5 commits into from
Oct 25, 2021
Merged

Support Apollo secret #1533

merged 5 commits into from
Oct 25, 2021

Conversation

zhaoyunxing92
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Support Apollo secret #1521
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2021

Codecov Report

Merging #1533 (daffbf6) into 3.0 (c1263de) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1533      +/-   ##
==========================================
+ Coverage   41.93%   42.10%   +0.17%     
==========================================
  Files         259      259              
  Lines       15132    15126       -6     
==========================================
+ Hits         6345     6369      +24     
+ Misses       8047     8017      -30     
  Partials      740      740              
Impacted Files Coverage Δ
config/config_center_config.go 54.00% <ø> (+39.14%) ⬆️
config_center/apollo/impl.go 72.97% <100.00%> (-1.72%) ⬇️
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (-8.61%) ⬇️
...tocol/rest/server/server_impl/go_restful_server.go 41.37% <0.00%> (-3.45%) ⬇️
config/root_config.go 35.00% <0.00%> (+0.62%) ⬆️
remoting/kubernetes/listener.go 54.71% <0.00%> (+1.88%) ⬆️
remoting/kubernetes/client.go 74.15% <0.00%> (+2.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1263de...daffbf6. Read the comment docs.

go.mod Outdated
@@ -51,3 +51,6 @@ require (
k8s.io/apimachinery v0.16.9
k8s.io/client-go v0.16.9
)
replace (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace内是空的,这是何意?

_ "dubbo.apache.org/dubbo-go/v3/config_center/apollo"
"github.com/stretchr/testify/assert"
"testing"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format import block please.

@LaurenceLiZhixin LaurenceLiZhixin merged commit b1a1617 into apache:3.0 Oct 25, 2021
justxuewei pushed a commit to justxuewei/dubbo-go that referenced this pull request Oct 28, 2021
* add:apollo config center

* fmt

* fmt

* fix:apollo namespace

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants