-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr: Support Custom Registry GroupName on Nacos #1353
Ftr: Support Custom Registry GroupName on Nacos #1353
Conversation
不应复用service_discovery配置,应与Java一样使用registry.group |
Pls make your ut pass, tks. |
…_service_group_name_on_nacos
Codecov Report
@@ Coverage Diff @@
## 3.0 #1353 +/- ##
==========================================
+ Coverage 41.82% 41.91% +0.08%
==========================================
Files 259 259
Lines 15120 15132 +12
==========================================
+ Hits 6324 6342 +18
+ Misses 8058 8051 -7
- Partials 738 739 +1
Continue to review full report at Codecov.
|
@LaurenceLiZhixin Done. |
…_service_group_name_on_nacos
这个pr可以先缓缓,需要考虑的地方有点多 |
…_service_group_name_on_nacos
What this PR does:
Which issue(s) this PR fixes:
Fixes #1139
Special notes for your reviewer:
config:
providers:
consumers:
center:
Does this PR introduce a user-facing change?: