Rft: Filter #1299
Merged
Rft: Filter #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix config name fix name problems update for code style temp sync sync refactor filter done
Codecov Report
@@ Coverage Diff @@
## 3.0 #1299 +/- ##
==========================================
- Coverage 59.53% 55.77% -3.76%
==========================================
Files 259 273 +14
Lines 12737 12796 +59
==========================================
- Hits 7583 7137 -446
- Misses 4199 4741 +542
+ Partials 955 918 -37
Continue to review full report at Codecov.
|
LaurenceLiZhixin
approved these changes
Jul 6, 2021
|
可以再仔细看下接口的命名，这次改了之后尽量杜绝接口名的改动。 |
fangyincheng
reviewed
Jul 6, 2021
目前接口名基本上可以做到不需要再改了，同时加入了filter_impl包用于与旧版代码兼容，如果以后能在dubbogo/imports项目中或者代码中给出import实例，后续可以把filter_impl删除。 |
justxuewei
commented
Jul 7, 2021
| @@ -62,12 +62,12 @@ func TestProtocolFilterWrapperRefer(t *testing.T) { | |||
|
|
|||
| // the same as echo filter, for test | |||
| func init() { | |||
| extension.SetFilter("echo", GetFilter) | |||
| extension.SetFilter("echo", newFilter) | |||
| } | |||
There was a problem hiding this comment.
Is this not affected the real EchoFilter? (If this SetFilter is performed after real EchoFilter 's SetFilter) @LaurenceLiZhixin
Mulavar
approved these changes
Jul 7, 2021
AlexStocks
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
filter_implto subpackageWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
filter_implis reserved and ensures users use the filters without modifying the code.Does this PR introduce a user-facing change?: