Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loadbalance unit test #1270

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Conversation

LaurenceLiZhixin
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@LaurenceLiZhixin LaurenceLiZhixin added this to the v3.0.0-rc2 milestone Jun 21, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1270 (434b419) into 3.0 (968650f) will decrease coverage by 3.87%.
The diff coverage is 50.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1270      +/-   ##
==========================================
- Coverage   59.53%   55.65%   -3.88%     
==========================================
  Files         259      272      +13     
  Lines       12737    12809      +72     
==========================================
- Hits         7583     7129     -454     
- Misses       4199     4780     +581     
+ Partials      955      900      -55     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
...router/v3router/judger/list_string_match_judger.go 0.00% <0.00%> (ø)
...ster/router/v3router/judger/method_match_judger.go 0.00% <0.00%> (ø)
...er/router/v3router/judger/url_label_match_judge.go 0.00% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
... and 284 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca2a46f...434b419. Read the comment docs.

@LaurenceLiZhixin LaurenceLiZhixin merged commit fc2cd0d into apache:3.0 Jun 21, 2021
@AlexStocks
Copy link
Contributor

LGTM

EnableAsync pushed a commit to EnableAsync/dubbo-go that referenced this pull request Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants