Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tst: Add unit tests for app metadata reporter of zookeeper #1229

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

justxuewei
Copy link
Member

@justxuewei justxuewei commented May 30, 2021

What this PR does:

As the name implied, unit tests for app metadata reporter of zookeeper are added.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

Codecov Report

Merging #1229 (cd59f00) into 3.0 (968650f) will decrease coverage by 3.58%.
The diff coverage is 50.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1229      +/-   ##
==========================================
- Coverage   59.53%   55.94%   -3.59%     
==========================================
  Files         259      272      +13     
  Lines       12737    12880     +143     
==========================================
- Hits         7583     7206     -377     
- Misses       4199     4777     +578     
+ Partials      955      897      -58     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
...router/v3router/judger/list_string_match_judger.go 0.00% <0.00%> (ø)
...ster/router/v3router/judger/method_match_judger.go 0.00% <0.00%> (ø)
...er/router/v3router/judger/url_label_match_judge.go 0.00% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
... and 275 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9ee29d...cd59f00. Read the comment docs.

@AlexStocks AlexStocks merged commit d32458b into apache:3.0 Jun 2, 2021
@LaurenceLiZhixin LaurenceLiZhixin added this to the v3.0.0-rc2 milestone Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants