Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency prompting for unittest #1212

Merged
merged 12 commits into from
May 24, 2021
Merged

dependency prompting for unittest #1212

merged 12 commits into from
May 24, 2021

Conversation

justxuewei
Copy link
Member

What this PR does:

  • prompt dependency requirements for metadata/report/zookeeper/report_test.go unittest

Does this PR introduce a user-facing change?:

NONE

@AlexStocks AlexStocks changed the base branch from develop to 3.0 May 23, 2021 11:04
Copy link
Contributor

@zhaoyunxing92 zhaoyunxing92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved these changes

@codecov-commenter
Copy link

Codecov Report

Merging #1212 (e22291d) into 3.0 (968650f) will decrease coverage by 3.66%.
The diff coverage is 50.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1212      +/-   ##
==========================================
- Coverage   59.53%   55.87%   -3.67%     
==========================================
  Files         259      272      +13     
  Lines       12737    12860     +123     
==========================================
- Hits         7583     7185     -398     
- Misses       4199     4776     +577     
+ Partials      955      899      -56     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
...router/v3router/judger/list_string_match_judger.go 0.00% <0.00%> (ø)
...ster/router/v3router/judger/method_match_judger.go 0.00% <0.00%> (ø)
...er/router/v3router/judger/url_label_match_judge.go 0.00% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
... and 275 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f83b1a...e22291d. Read the comment docs.

@AlexStocks AlexStocks merged commit 56fa17f into apache:3.0 May 24, 2021
@LaurenceLiZhixin LaurenceLiZhixin added this to the v3.0.0-rc2 milestone Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants