Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry times in zookeeper starting #1179

Merged
merged 9 commits into from
May 7, 2021
Merged

Conversation

Patrick0308
Copy link
Contributor

@Patrick0308 Patrick0308 commented Apr 27, 2021

What this PR does:
Zookeeper client can not be connect to server in some tests.

ztelur and others added 4 commits May 6, 2021 18:06
* fix etcd problem

* fix metadata report etcd problem

* fix nacos & cluster_impl ci problem

* fix nacos ci problem

* fix zk ci problem

* fix zk metadata service urls not found error

* fix zk TestAddListenerZookeeperServiceDiscovery

* fix zk TestAddListenerZookeeperServiceDiscovery

* fix config int to string bug
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2021

Codecov Report

Merging #1179 (4fb32ac) into 3.0 (968650f) will decrease coverage by 2.96%.
The diff coverage is 53.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1179      +/-   ##
==========================================
- Coverage   59.53%   56.57%   -2.97%     
==========================================
  Files         259      254       -5     
  Lines       12737    12485     -252     
==========================================
- Hits         7583     7063     -520     
- Misses       4199     4538     +339     
+ Partials      955      884      -71     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
common/extension/config_center.go 0.00% <ø> (ø)
common/extension/config_center_factory.go 0.00% <ø> (ø)
common/extension/config_post_processor.go 0.00% <0.00%> (ø)
common/extension/configurator.go 0.00% <ø> (ø)
... and 217 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279ccd2...4fb32ac. Read the comment docs.

@AlexStocks AlexStocks merged commit f421172 into apache:3.0 May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants