-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add retry times in zookeeper starting #1179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* replace default config string with const value * delete some duplicate keys Co-authored-by: dongjianhui <[email protected]>
gaoxinge
reviewed
May 1, 2021
* fix etcd problem * fix metadata report etcd problem * fix nacos & cluster_impl ci problem * fix nacos ci problem * fix zk ci problem * fix zk metadata service urls not found error * fix zk TestAddListenerZookeeperServiceDiscovery * fix zk TestAddListenerZookeeperServiceDiscovery * fix config int to string bug
Codecov Report
@@ Coverage Diff @@
## 3.0 #1179 +/- ##
==========================================
- Coverage 59.53% 56.57% -2.97%
==========================================
Files 259 254 -5
Lines 12737 12485 -252
==========================================
- Hits 7583 7063 -520
- Misses 4199 4538 +339
+ Partials 955 884 -71
Continue to review full report at Codecov.
|
LaurenceLiZhixin
approved these changes
May 7, 2021
AlexStocks
approved these changes
May 7, 2021
gaoxinge
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Zookeeper client can not be connect to server in some tests.