-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr: Add an "api way" to set general configure #1020
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1020 +/- ##
===========================================
+ Coverage 59.54% 59.74% +0.20%
===========================================
Files 261 262 +1
Lines 12957 13152 +195
===========================================
+ Hits 7715 7858 +143
- Misses 4266 4316 +50
- Partials 976 978 +2
Continue to review full report at Codecov.
|
} | ||
} | ||
|
||
///////////////////////////////////////// Application config api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base on security, I am not agree with modify configuration by web API .
pls change the target branch to 1.5 |
This pull request may correspond to the dubbo java's api configuration. I think this is a nice configuration feature for people who start to use dubbo-go. @AlexStocks @zouyx |
I will agree,if not web API . |
very good pr. however, u should add comment for every func. |
Ftr: Add an "api way" to set general configure
What this PR does:
This pr add an "API way" to set general configure.
Usage can be found at my branch:
https://github.com/LaurenceLiZhixin/dubbo-go-samples/blob/ftr/samples-add/config-api/go-client/cmd/client.go
or in test file
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: