Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Proxy with ImplementFunc to allow override impl #1019

Merged
merged 3 commits into from
Feb 4, 2021
Merged

Refactor Proxy with ImplementFunc to allow override impl #1019

merged 3 commits into from
Feb 4, 2021

Conversation

chenxxpro
Copy link
Contributor

What this PR does:

Ftr: Add Prox ImplementFunc to allow override impl

重构Proxy,添加ImplementFunc函数,允许项目对Proxy的代理实现进行重新实现。

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

在网关泛调用场景下,当前GenericService实现需要修改对返回数据的处理逻辑。
目前ProxyFactory允许自定义注册,但其创建的proxy.Proxy无法重新实现。

Ftr: Add Proxy ImplementFunc to allow override impl 

common/proxy/proxy.go Outdated Show resolved Hide resolved
common/proxy/proxy.go Outdated Show resolved Hide resolved
common/proxy/proxy.go Outdated Show resolved Hide resolved
@chenxxpro
Copy link
Contributor Author

Rename and format code, Done

@zouyx zouyx added the improve Refactor or improve label Jan 28, 2021
@AlexStocks
Copy link
Contributor

pls change the target branch to 1.5

@chenxxpro chenxxpro changed the base branch from develop to 1.5 February 4, 2021 01:27
@chenxxpro
Copy link
Contributor Author

pls change the target branch to 1.5

Done

@cityiron cityiron added this to the v1.5.6 milestone Feb 4, 2021
@cityiron
Copy link
Contributor

cityiron commented Feb 4, 2021

Tks, I will merge to 1.5 and add this for 1.5.6

@cityiron cityiron merged commit 7d0b63a into apache:1.5 Feb 4, 2021
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
Refactor Proxy with ImplementFunc to allow override impl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve Refactor or improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants