fix subscribe from registry

apache · Feb 6, 2025 · 2c799e2 · 2c799e2
1 parent bb9273d
commit 2c799e2
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/registry/directory/directory.go b/registry/directory/directory.go
@@ -124,12 +124,20 @@ func (dir *RegistryDirectory) Subscribe(url *common.URL) error {
 	registerUrl := dir.registry.GetURL()
 
 	var timeoutStr string
-	if registerUrl == nil {
-		timeoutStr = url.GetParam(constant.TimeoutKey, "1s")
-	} else {
-		timeoutStr = registerUrl.GetParam(constant.RegistryTimeoutKey, "")
+
+	if registerUrl != nil {
+		if val := registerUrl.GetParam(constant.RegistryTimeoutKey, ""); val != "" {
+			timeoutStr = val
+		}
 	}
-	timeout, _ := time.ParseDuration(timeoutStr)
+
+	timeout, err := time.ParseDuration(timeoutStr)
+	if err != nil {
+		logger.Warnf("Invalid timeout value %s, using default %s", timeoutStr, constant.DefaultRegTimeout)
+		timeout, _ = time.ParseDuration(constant.DefaultRegTimeout)
+	}
+
+	fmt.Println("timeout:\n\n", timeout)
 
 	done := make(chan struct{})