Ftr: add fatal method for logger(config-enhance branch) (#1482)

* feat: add fatal method for logger

* test: add test for logger fatal & fatalf

common/logger/logger.go

@@ -50,11 +50,13 @@ type Logger interface {
 	Warn(args ...interface{})
 	Error(args ...interface{})
 	Debug(args ...interface{})
+	Fatal(args ...interface{})
 
 	Infof(fmt string, args ...interface{})
 	Warnf(fmt string, args ...interface{})
 	Errorf(fmt string, args ...interface{})
 	Debugf(fmt string, args ...interface{})
+	Fatalf(fmt string, args ...interface{})
 }
 
 // InitLogger use for init logger by @conf

common/logger/logging.go

@@ -56,3 +56,13 @@ func Errorf(fmt string, args ...interface{}) {
 func Debugf(fmt string, args ...interface{}) {
 	logger.Debugf(fmt, args...)
 }
+
+// Fatal logs a message, then calls os.Exit.
+func Fatal(args ...interface{}) {
+	logger.Fatal(args...)
+}
+
+// Fatalf logs a templated message, then calls os.Exit.
+func Fatalf(fmt string, args ...interface{}) {
+	logger.Fatalf(fmt, args...)
+}

config/logger_config_test.go

@@ -18,17 +18,23 @@
 package config
 
 import (
+	"os"
 	"testing"
 )
 
 import (
+	"bou.ke/monkey"
 	"github.com/stretchr/testify/assert"
 )
 
 import (
 	"dubbo.apache.org/dubbo-go/v3/common/logger"
 )
 
+func fakeExit(int) {
+	panic("os.Exit called")
+}
+
 func TestLoggerInit(t *testing.T) {
 	t.Run("empty use default", func(t *testing.T) {
 		err := Load(WithPath("./testdata/config/logger/empty_log.yaml"))
@@ -38,6 +44,14 @@ func TestLoggerInit(t *testing.T) {
 		assert.NotNil(t, loggerConfig)
 		assert.Equal(t, []string{"stderr"}, loggerConfig.ZapConfig.OutputPaths)
 		logger.Info("hello")
+		patch := monkey.Patch(os.Exit, fakeExit)
+		defer patch.Unpatch()
+		assert.PanicsWithValue(t, "os.Exit called", func() {
+			logger.Fatalf("%s", "error")
+		}, "os.Exit was not called")
+		assert.PanicsWithValue(t, "os.Exit called", func() {
+			logger.Fatal("error")
+		}, "os.Exit was not called")
 	})
 
 	t.Run("use config", func(t *testing.T) {

go.mod

@@ -3,6 +3,7 @@ module dubbo.apache.org/dubbo-go/v3
 go 1.15
 
 require (
+	bou.ke/monkey v1.0.2
 	github.com/RoaringBitmap/roaring v0.7.1
 	github.com/Workiva/go-datastructures v1.0.52
 	github.com/afex/hystrix-go v0.0.0-20180502004556-fa1af6a1f4f5

go.sum

@@ -1,4 +1,6 @@
 bazil.org/fuse v0.0.0-20160811212531-371fbbdaa898/go.mod h1:Xbm+BRKSBEpa4q4hTSxohYNQpsxXPbPry4JJWOB3LB8=
+bou.ke/monkey v1.0.2 h1:kWcnsrCNUatbxncxR/ThdYqbytgOIArtYWqcQLQzKLI=
+bou.ke/monkey v1.0.2/go.mod h1:OqickVX3tNx6t33n1xvtTtu85YN5s6cKwVug+oHMaIA=
 cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
 cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
 cloud.google.com/go v0.38.0/go.mod h1:990N+gfupTy94rShfmMCWGDn0LpTmnzTp2qbd1dvSRU=