fix not writing class name first when encoding pojo map #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
==========================================
+ Coverage 70.47% 70.50% +0.03%
==========================================
Files 27 27
Lines 3119 3123 +4
==========================================
+ Hits 2198 2202 +4
Misses 687 687
Partials 234 234
Continue to review full report at Codecov.
|
AlexStocks
approved these changes
Jul 15, 2022
|
@zhengzepeng pls add an ut for this pr. |
ok |
|
@zhengzepeng I have merged your pr. pls upgrade the hessian-go version in dubbo-go and dubbo-go-samples. |
wongoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
if map is pojo, write class name first
Which issue(s) this PR fixes:
#319
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: