MSQ: Consider PARTITION_STATS_MAX_BYTES in WorkerMemoryParameters. #13274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianm
added
the
Area - MSQ
This consideration is important, because otherwise we can run out of memory due to large statistics-tracking objects.
cryptoe
reviewed
Oct 28, 2022
|
|
||
| // Need to subtract memoryForStatisticsTracking off the top, since this is reserved for statistics collection. | ||
| final long memoryForStatisticsTracking = (long) numWorkersInJvm * StageDefinition.PARTITION_STATS_MAX_BYTES; | ||
| final long memoryForBundles = (long) (maxMemoryInJvm * USABLE_MEMORY_FRACTION - memoryForStatisticsTracking); |
There was a problem hiding this comment.
Should we add a > 0 check here? That way the user knows that he needs to give more memory to the task
There was a problem hiding this comment.
There's a reasonable error that occurs later on; see WorkerMemoryParametersTest.
cryptoe
approved these changes
Nov 3, 2022
| @@ -216,6 +219,10 @@ void start() | |||
| */ | |||
| void finish() | |||
| { | |||
| if (resultKeyStatisticsCollector != null) { | |||
| resultKeyStatisticsCollector.clear(); | |||
| ) | ||
| { | ||
| final long usableMemory = (long) (maxMemoryInJvm * USABLE_MEMORY_FRACTION); | ||
| final long memoryForWorkers = (long) Math.min( |
There was a problem hiding this comment.
Nice. This is really cool and will go a long way in fixing the memory issues of sketches.
|
We might have to update this line |
|
Pushed an update fixing merge conflicts, updating |
|
🚀 |
This was referenced Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consideration is important, because otherwise we can run out of memory due to large statistics-tracking objects.