Skip to content

DRILL-7018: Fixed Parquet buffer overflow when reading timestamp column #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sachouche wants to merge 1 commit into from
Closed

DRILL-7018: Fixed Parquet buffer overflow when reading timestamp column #1630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...va/org/apache/drill/exec/store/parquet/columnreaders/NullableFixedByteAlignedReaders.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ static class NullableFixedBinaryAsTimeStampReader extends NullableFixedByteAlign
NullableFixedBinaryAsTimeStampReader(ParquetRecordReader parentReader, ColumnDescriptor descriptor,
ColumnChunkMetaData columnChunkMetaData, boolean fixedLength, NullableTimeStampVector v, SchemaElement schemaElement) throws ExecutionSetupException {
super(parentReader, descriptor, columnChunkMetaData, fixedLength, v, schemaElement);

// The width of each element of the TimeStampVector is 8 bytes (64 bits) instead of 12 bytes.
dataTypeLengthInBits = NullableTimeStampHolder.WIDTH * 8;
}

@Override
Expand All @@ -127,8 +130,6 @@ protected void readField(long recordsToReadInThisPass) {
valueVec.getMutator().setSafe(valuesReadInCurrentPass + i, getDateTimeValueFromBinary(binaryTimeStampValue, true));
}
}
// The width of each element of the TimeStampVector is 8 bytes (64 bits) instead of 12 bytes.
dataTypeLengthInBits = NullableTimeStampHolder.WIDTH * 8;
}
}

Expand Down