Skip to content

DRILL-6447: Fixed a sanity check condition #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sachouche wants to merge 1 commit into from
Closed

DRILL-6447: Fixed a sanity check condition #1291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/PageReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,8 +445,8 @@ public void clear(){
* @throws IOException An IO related condition
*/
void resetDefinitionLevelReader(int skipCount) throws IOException {
if (parentColumnReader.columnDescriptor.getMaxDefinitionLevel() != 0) {
throw new UnsupportedOperationException("Unsupoorted Operation");
if (parentColumnReader.columnDescriptor.getMaxDefinitionLevel() > 1) {
Copy link
Member

@vrozov vrozov May 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already part of Parquet version upgrade (see PR #1259), no need to fix it.

throw new UnsupportedOperationException("Unsupported Operation");
}

final Encoding dlEncoding = METADATA_CONVERTER.getEncoding(pageHeader.data_page_header.definition_level_encoding);
Expand Down
2 changes: 2 additions & 0 deletions ...src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBulkPageReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ final class VarLenBulkPageReader {
this.pageInfo.numPageFieldsRead = pageInfoInput.numPageFieldsRead;
this.pageInfo.definitionLevels = pageInfoInput.definitionLevels;
this.pageInfo.dictionaryValueReader = pageInfoInput.dictionaryValueReader;
this.pageInfo.numPageValues = pageInfoInput.numPageValues;
}

this.columnPrecInfo = columnPrecInfoInput;
Expand All @@ -94,6 +95,7 @@ final void set(PageDataInfo pageInfoInput) {
pageInfo.numPageFieldsRead = pageInfoInput.numPageFieldsRead;
pageInfo.definitionLevels = pageInfoInput.definitionLevels;
pageInfo.dictionaryValueReader = pageInfoInput.dictionaryValueReader;
pageInfo.numPageValues = pageInfoInput.numPageValues;

buffer.clear();
}
Expand Down