Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](deps) miss build_jindofs in build-thirdparty.sh #49371

Merged
merged 3 commits into from
Mar 23, 2025
Merged

[fix](deps) miss build_jindofs in build-thirdparty.sh #49371

merged 3 commits into from
Mar 23, 2025

Conversation

morningman
Copy link
Contributor

Follow up #49259
Forget to call build_jindofs in build-thirdparty.sh

@morningman morningman marked this pull request as ready for review March 23, 2025 02:51
@Thearas
Copy link
Contributor

Thearas commented Mar 23, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34224 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5a5784ea591a7ea5fac30f5f1dc31e4f625f74f5, data reload: false

------ Round 1 ----------------------------------
q1	24022	5096	5094	5094
q2	2050	309	176	176
q3	10374	1233	675	675
q4	10223	995	534	534
q5	7493	2209	2376	2209
q6	187	169	134	134
q7	905	770	638	638
q8	9299	1348	1110	1110
q9	6840	5137	5103	5103
q10	6809	2316	1902	1902
q11	469	272	254	254
q12	347	355	221	221
q13	17770	3722	3121	3121
q14	222	231	206	206
q15	521	483	493	483
q16	632	619	580	580
q17	568	843	338	338
q18	7481	7233	7224	7224
q19	1237	954	587	587
q20	319	325	196	196
q21	3882	3347	2489	2489
q22	1068	997	950	950
Total cold run time: 112718 ms
Total hot run time: 34224 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5179	5149	5163	5149
q2	242	325	233	233
q3	2127	2644	2407	2407
q4	1468	1833	1405	1405
q5	4434	4459	4480	4459
q6	221	167	131	131
q7	2058	1971	1853	1853
q8	2622	2894	2632	2632
q9	7314	7228	7070	7070
q10	2999	3197	2732	2732
q11	572	508	494	494
q12	688	769	641	641
q13	3460	3901	3294	3294
q14	279	320	280	280
q15	522	473	496	473
q16	671	697	641	641
q17	1152	1615	1357	1357
q18	7814	7488	7357	7357
q19	850	840	965	840
q20	1958	2044	1860	1860
q21	5209	4963	4896	4896
q22	1090	1074	1037	1037
Total cold run time: 52929 ms
Total hot run time: 51241 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194225 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5a5784ea591a7ea5fac30f5f1dc31e4f625f74f5, data reload: false

query1	1400	1056	1031	1031
query2	6183	1951	1924	1924
query3	10965	4444	4450	4444
query4	25261	23855	23631	23631
query5	5131	663	478	478
query6	311	202	199	199
query7	3990	494	278	278
query8	309	249	239	239
query9	8540	2596	2589	2589
query10	512	315	270	270
query11	15590	15151	14858	14858
query12	163	109	106	106
query13	1576	530	391	391
query14	10390	6183	6316	6183
query15	185	181	173	173
query16	7614	646	488	488
query17	1282	706	571	571
query18	2059	412	313	313
query19	198	225	181	181
query20	123	117	122	117
query21	204	125	107	107
query22	4604	4573	4540	4540
query23	34292	33735	33395	33395
query24	7523	2450	2458	2450
query25	502	471	421	421
query26	1235	267	153	153
query27	2603	480	344	344
query28	4589	2434	2419	2419
query29	704	579	459	459
query30	280	218	189	189
query31	898	874	833	833
query32	73	66	66	66
query33	548	380	330	330
query34	801	865	514	514
query35	821	860	755	755
query36	977	1022	902	902
query37	120	103	85	85
query38	4430	4180	4075	4075
query39	1499	1453	1448	1448
query40	214	117	104	104
query41	53	53	50	50
query42	127	106	108	106
query43	513	516	494	494
query44	1347	812	814	812
query45	173	178	162	162
query46	849	1036	658	658
query47	1852	1863	1771	1771
query48	396	412	309	309
query49	774	532	496	496
query50	718	753	441	441
query51	4320	4293	4297	4293
query52	105	105	98	98
query53	231	258	186	186
query54	489	505	426	426
query55	80	88	83	83
query56	300	290	265	265
query57	1201	1184	1101	1101
query58	272	240	240	240
query59	2854	2864	2742	2742
query60	295	290	267	267
query61	135	140	131	131
query62	804	777	698	698
query63	272	191	193	191
query64	4249	1046	700	700
query65	4556	4439	4461	4439
query66	1003	394	314	314
query67	16072	15442	15271	15271
query68	7914	877	502	502
query69	467	320	263	263
query70	1200	1158	1134	1134
query71	438	295	262	262
query72	5317	5182	5096	5096
query73	650	577	349	349
query74	8949	9049	8962	8962
query75	3231	3243	2699	2699
query76	3196	1196	778	778
query77	478	370	287	287
query78	10067	10204	9409	9409
query79	2711	782	570	570
query80	649	510	452	452
query81	498	251	219	219
query82	709	124	96	96
query83	172	172	160	160
query84	242	92	76	76
query85	885	347	311	311
query86	377	313	301	301
query87	4433	4507	4383	4383
query88	4100	2277	2264	2264
query89	396	319	280	280
query90	2041	210	212	210
query91	163	143	117	117
query92	78	59	56	56
query93	2611	1038	577	577
query94	694	407	274	274
query95	353	277	268	268
query96	480	562	272	272
query97	3306	3397	3345	3345
query98	233	200	209	200
query99	1338	1416	1256	1256
Total cold run time: 281115 ms
Total hot run time: 194225 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.26 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5a5784ea591a7ea5fac30f5f1dc31e4f625f74f5, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.11	0.10
query3	0.25	0.19	0.19
query4	1.59	0.19	0.20
query5	0.58	0.58	0.58
query6	1.20	0.72	0.72
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.53	0.55
query10	0.59	0.61	0.57
query11	0.16	0.11	0.11
query12	0.14	0.11	0.11
query13	0.62	0.61	0.61
query14	2.68	2.68	2.69
query15	0.93	0.85	0.84
query16	0.39	0.39	0.37
query17	1.02	0.99	1.06
query18	0.21	0.20	0.20
query19	1.91	1.98	1.90
query20	0.01	0.01	0.01
query21	15.36	0.90	0.54
query22	0.77	1.06	0.62
query23	15.15	1.38	0.57
query24	7.52	1.04	1.13
query25	0.51	0.23	0.13
query26	0.72	0.17	0.13
query27	0.05	0.06	0.04
query28	8.51	0.86	0.43
query29	12.54	3.98	3.29
query30	0.25	0.09	0.06
query31	2.84	0.57	0.39
query32	3.23	0.55	0.48
query33	3.03	3.01	3.05
query34	15.77	5.12	4.48
query35	4.49	4.50	4.48
query36	0.68	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.18	0.14	0.12
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 105.01 s
Total hot run time: 31.26 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 49.96% (13369/26760)
Line Coverage 39.42% (115674/293407)
Region Coverage 38.12% (58707/154003)
Branch Coverage 33.26% (29628/89084)

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33788 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2a925cbffae050e38ceb521f45bda49c3b56dad9, data reload: false

------ Round 1 ----------------------------------
q1	24248	5033	4989	4989
q2	2045	307	168	168
q3	10393	1202	667	667
q4	10230	993	512	512
q5	7526	2402	2261	2261
q6	189	169	132	132
q7	905	733	611	611
q8	9304	1283	982	982
q9	6885	5114	5207	5114
q10	6809	2314	1928	1928
q11	511	273	256	256
q12	349	352	222	222
q13	17753	3652	3076	3076
q14	245	223	200	200
q15	520	491	499	491
q16	629	625	566	566
q17	565	846	330	330
q18	7657	7162	7122	7122
q19	1836	943	548	548
q20	301	312	206	206
q21	3868	2701	2431	2431
q22	1094	1059	976	976
Total cold run time: 113862 ms
Total hot run time: 33788 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5187	5063	5093	5063
q2	249	333	236	236
q3	2148	2647	2264	2264
q4	1398	1775	1409	1409
q5	4338	4374	4414	4374
q6	209	172	125	125
q7	2015	1927	1745	1745
q8	2598	2583	2562	2562
q9	7240	7225	7028	7028
q10	2978	3243	2758	2758
q11	562	529	489	489
q12	673	757	606	606
q13	3600	3906	3280	3280
q14	297	290	280	280
q15	531	480	472	472
q16	625	682	646	646
q17	1124	1550	1388	1388
q18	7748	7698	7611	7611
q19	787	786	839	786
q20	1925	1931	1825	1825
q21	5360	4937	4854	4854
q22	1092	1053	1079	1053
Total cold run time: 52684 ms
Total hot run time: 50854 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192904 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2a925cbffae050e38ceb521f45bda49c3b56dad9, data reload: false

query1	1383	1041	1024	1024
query2	6214	1907	1835	1835
query3	11166	4569	4580	4569
query4	53994	25935	22945	22945
query5	5257	528	499	499
query6	403	199	198	198
query7	5225	485	274	274
query8	330	253	236	236
query9	6839	2569	2581	2569
query10	417	313	256	256
query11	15606	15082	14860	14860
query12	162	113	108	108
query13	1258	513	386	386
query14	11006	6479	6271	6271
query15	198	187	184	184
query16	7040	652	497	497
query17	1098	781	622	622
query18	1507	381	318	318
query19	200	186	155	155
query20	129	122	117	117
query21	204	124	102	102
query22	4596	4461	4389	4389
query23	34074	33555	33200	33200
query24	5730	2408	2401	2401
query25	446	462	405	405
query26	733	267	144	144
query27	1808	467	363	363
query28	2749	2475	2444	2444
query29	594	547	426	426
query30	269	228	189	189
query31	887	879	799	799
query32	78	60	62	60
query33	453	362	290	290
query34	772	844	502	502
query35	828	841	783	783
query36	945	1014	884	884
query37	124	102	72	72
query38	4254	4309	4076	4076
query39	1479	1447	1449	1447
query40	213	129	107	107
query41	60	53	53	53
query42	120	106	103	103
query43	515	502	471	471
query44	1299	815	801	801
query45	186	168	165	165
query46	842	1053	640	640
query47	1809	1885	1833	1833
query48	379	423	322	322
query49	734	551	443	443
query50	713	764	427	427
query51	4306	4349	4257	4257
query52	103	105	97	97
query53	217	246	179	179
query54	486	480	409	409
query55	82	81	86	81
query56	307	287	255	255
query57	1206	1218	1118	1118
query58	255	240	260	240
query59	2852	2721	2656	2656
query60	295	270	275	270
query61	126	125	178	125
query62	714	736	685	685
query63	218	187	188	187
query64	2293	1077	691	691
query65	4514	4489	4447	4447
query66	806	391	294	294
query67	15867	15422	15596	15422
query68	7195	816	493	493
query69	522	314	259	259
query70	1204	1125	1070	1070
query71	549	290	254	254
query72	5943	5216	5380	5216
query73	1275	742	347	347
query74	8953	9250	8984	8984
query75	3768	3233	2754	2754
query76	4280	1197	740	740
query77	623	355	281	281
query78	10028	10196	9264	9264
query79	2204	861	569	569
query80	621	524	441	441
query81	485	257	226	226
query82	491	131	99	99
query83	174	237	154	154
query84	287	96	76	76
query85	808	361	308	308
query86	407	294	271	271
query87	4561	4493	4321	4321
query88	3525	2273	2258	2258
query89	394	312	281	281
query90	1887	213	210	210
query91	139	155	107	107
query92	77	60	61	60
query93	1566	1055	585	585
query94	665	413	306	306
query95	352	276	272	272
query96	480	563	276	276
query97	3377	3411	3231	3231
query98	232	210	206	206
query99	1673	1429	1308	1308
Total cold run time: 300717 ms
Total hot run time: 192904 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.26 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2a925cbffae050e38ceb521f45bda49c3b56dad9, data reload: false

query1	0.04	0.03	0.03
query2	0.13	0.10	0.11
query3	0.26	0.19	0.18
query4	1.59	0.21	0.20
query5	0.59	0.60	0.58
query6	1.19	0.72	0.71
query7	0.03	0.02	0.02
query8	0.04	0.03	0.04
query9	0.58	0.52	0.54
query10	0.57	0.59	0.57
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.62	0.60	0.60
query14	2.79	2.70	2.71
query15	0.94	0.85	0.86
query16	0.38	0.36	0.37
query17	1.04	1.02	1.07
query18	0.20	0.20	0.19
query19	1.94	1.94	1.84
query20	0.02	0.01	0.02
query21	15.35	0.95	0.56
query22	0.77	1.24	0.73
query23	14.80	1.43	0.66
query24	7.30	1.28	0.59
query25	0.51	0.27	0.12
query26	0.66	0.16	0.13
query27	0.05	0.05	0.05
query28	8.90	0.90	0.44
query29	12.53	4.10	3.41
query30	0.25	0.09	0.07
query31	2.84	0.60	0.39
query32	3.23	0.55	0.48
query33	2.97	3.02	3.07
query34	15.78	5.17	4.57
query35	4.59	4.60	4.52
query36	0.66	0.49	0.48
query37	0.09	0.07	0.06
query38	0.06	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.12	0.12
query41	0.09	0.03	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 104.95 s
Total hot run time: 31.26 s

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 49.97% (13372/26760)
Line Coverage 39.43% (115698/293408)
Region Coverage 38.13% (58721/154003)
Branch Coverage 33.27% (29641/89084)

@morningman morningman merged commit 0210cad into apache:master Mar 23, 2025
27 of 28 checks passed
@morningman morningman mentioned this pull request Mar 23, 2025
Merged
16 tasks
morningman added a commit that referenced this pull request Mar 24, 2025
@morningman
[feat](build) add jindofs jars by default for linux x64 & arm (#49374)
118ec7c 
### What problem does this PR solve?

Followup #49371

Problem Summary:

The `jindofs-core` and `jindofs-sdk` jars will be installed in `fe/lib`
and `be/lib/java_extensions/preload-extensions`.
So that user don't need to install these jars to access aliyun oss-hdfs
manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@wuwenchi wuwenchi wuwenchi approved these changes

@hubgeter hubgeter hubgeter approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/2.1.x-conflict dev/3.0.x dev/3.0.x-conflict reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@morningman @Thearas @doris-robot @hello-stephen @CalvinKirs @wuwenchi @hubgeter