Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](ob catalog) fix oceanbase catalog get connection #48593

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Mar 4, 2025

close #48484
When Oceanbase is created, the test statement for getting the connection should be 'select 1 from dual', because this is compatible with both Oracle and MySQL modes.

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk zy-kkk added usercase Important user case type label dev/2.1.x dev/3.0.x labels Mar 4, 2025
@zy-kkk
Copy link
Member Author

zy-kkk commented Mar 4, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32008 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 39d6e2371e9aec29b55274b33fc42fa28f4f70c9, data reload: false

------ Round 1 ----------------------------------
q1	17590	5416	5184	5184
q2	2054	317	174	174
q3	10507	1260	793	793
q4	10221	1055	524	524
q5	7626	2442	2347	2347
q6	200	169	130	130
q7	921	768	618	618
q8	9307	1456	1226	1226
q9	5028	4957	4740	4740
q10	6843	2342	1892	1892
q11	476	276	262	262
q12	350	362	223	223
q13	17759	3726	3099	3099
q14	230	219	218	218
q15	524	459	451	451
q16	637	624	586	586
q17	590	916	351	351
q18	6965	6223	6194	6194
q19	1471	982	567	567
q20	317	327	182	182
q21	2857	2154	1939	1939
q22	368	338	308	308
Total cold run time: 102841 ms
Total hot run time: 32008 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5113	5314	5341	5314
q2	242	335	232	232
q3	2176	2662	2267	2267
q4	1472	1861	1382	1382
q5	4240	4125	4153	4125
q6	219	162	130	130
q7	1891	1842	1742	1742
q8	2669	2743	2642	2642
q9	7314	7235	7172	7172
q10	3042	3225	2798	2798
q11	569	505	491	491
q12	693	807	634	634
q13	3375	3986	3266	3266
q14	288	292	282	282
q15	515	478	461	461
q16	674	694	644	644
q17	1185	1644	1395	1395
q18	7529	7385	7303	7303
q19	879	950	1049	950
q20	1983	2089	1872	1872
q21	5556	4997	4757	4757
q22	651	577	533	533
Total cold run time: 52275 ms
Total hot run time: 50392 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190351 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 39d6e2371e9aec29b55274b33fc42fa28f4f70c9, data reload: false

query1	1295	957	940	940
query2	6225	1881	1893	1881
query3	11021	4450	4553	4450
query4	55803	25407	23416	23416
query5	5068	541	487	487
query6	343	192	187	187
query7	4927	501	296	296
query8	332	267	239	239
query9	5692	2553	2562	2553
query10	435	329	269	269
query11	15287	14975	14884	14884
query12	156	109	124	109
query13	1056	520	383	383
query14	10579	6494	6397	6397
query15	227	191	180	180
query16	7103	638	454	454
query17	1060	715	540	540
query18	1533	407	300	300
query19	198	197	165	165
query20	121	123	130	123
query21	208	123	103	103
query22	4713	4754	4423	4423
query23	34231	33278	33065	33065
query24	5710	2449	2450	2449
query25	462	466	411	411
query26	675	276	155	155
query27	1682	501	336	336
query28	2908	2465	2441	2441
query29	558	555	442	442
query30	217	194	164	164
query31	907	873	800	800
query32	79	67	68	67
query33	476	378	322	322
query34	773	887	509	509
query35	812	867	766	766
query36	974	992	908	908
query37	122	101	77	77
query38	4231	4232	4154	4154
query39	1473	1452	1422	1422
query40	222	119	112	112
query41	61	55	53	53
query42	128	110	108	108
query43	513	533	490	490
query44	1338	833	845	833
query45	188	180	169	169
query46	912	1055	671	671
query47	1850	1870	1778	1778
query48	396	429	356	356
query49	726	529	426	426
query50	730	764	421	421
query51	4270	4289	4320	4289
query52	108	111	100	100
query53	236	274	199	199
query54	512	497	437	437
query55	85	80	82	80
query56	271	282	295	282
query57	1159	1180	1122	1122
query58	247	238	255	238
query59	2880	2742	2718	2718
query60	286	278	267	267
query61	123	114	161	114
query62	742	727	711	711
query63	230	187	189	187
query64	1529	1048	679	679
query65	3361	3264	3170	3170
query66	803	388	295	295
query67	15708	15517	15426	15426
query68	7292	820	504	504
query69	537	298	263	263
query70	1212	1122	1114	1114
query71	499	300	255	255
query72	5850	3541	3884	3541
query73	1495	733	353	353
query74	9047	9150	8863	8863
query75	3670	3165	2711	2711
query76	4152	1178	749	749
query77	586	391	282	282
query78	10116	9984	9285	9285
query79	2667	813	597	597
query80	616	522	450	450
query81	520	280	251	251
query82	606	123	90	90
query83	308	178	152	152
query84	296	99	72	72
query85	845	354	316	316
query86	413	318	286	286
query87	4559	4484	4309	4309
query88	3716	2207	2159	2159
query89	420	318	282	282
query90	1891	189	189	189
query91	139	138	116	116
query92	70	58	55	55
query93	2001	1060	589	589
query94	645	405	290	290
query95	346	263	253	253
query96	486	558	271	271
query97	3317	3407	3269	3269
query98	230	204	202	202
query99	1429	1441	1235	1235
Total cold run time: 299262 ms
Total hot run time: 190351 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.64 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 39d6e2371e9aec29b55274b33fc42fa28f4f70c9, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.23	0.07	0.06
query4	1.63	0.10	0.10
query5	0.56	0.55	0.54
query6	1.17	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.58	0.54	0.52
query10	0.58	0.57	0.57
query11	0.16	0.12	0.11
query12	0.14	0.11	0.12
query13	0.61	0.60	0.60
query14	2.79	2.81	2.80
query15	0.91	0.85	0.85
query16	0.38	0.38	0.38
query17	1.02	1.00	1.02
query18	0.21	0.20	0.20
query19	1.85	1.81	1.98
query20	0.01	0.01	0.01
query21	15.35	0.91	0.54
query22	0.75	1.16	0.61
query23	15.03	1.39	0.62
query24	7.42	0.71	1.56
query25	0.52	0.21	0.13
query26	0.54	0.17	0.14
query27	0.04	0.05	0.05
query28	9.85	0.89	0.43
query29	12.56	3.89	3.23
query30	0.25	0.10	0.06
query31	2.81	0.59	0.38
query32	3.24	0.57	0.46
query33	3.03	3.09	3.01
query34	15.74	5.10	4.48
query35	4.51	4.47	4.50
query36	0.65	0.50	0.49
query37	0.10	0.07	0.07
query38	0.05	0.04	0.04
query39	0.02	0.02	0.02
query40	0.18	0.14	0.12
query41	0.09	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 105.79 s
Total hot run time: 30.64 s

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 5, 2025
Copy link
Contributor

github-actions bot commented Mar 5, 2025

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Mar 5, 2025

PR approved by anyone and no changes requested.

@morningman morningman merged commit f7d0f3e into apache:master Mar 7, 2025
32 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 7, 2025
close #48484
When Oceanbase is created, the test statement for getting the connection
should be 'select 1 from dual', because this is compatible with both
Oracle and MySQL modes.
github-actions bot pushed a commit that referenced this pull request Mar 7, 2025
close #48484
When Oceanbase is created, the test statement for getting the connection
should be 'select 1 from dual', because this is compatible with both
Oracle and MySQL modes.
yiguolei pushed a commit that referenced this pull request Mar 11, 2025
dataroaring pushed a commit that referenced this pull request Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.5-merged reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] cannot connect to Oceanbase catalog
8 participants