Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](sql_cache) fix sql cache result wrong of from_unixtime(col, 'yyyy-MM-dd HH:mm:ss') #44631

Merged
merged 1 commit into from
Nov 27, 2024
Merged

[fix](sql_cache) fix sql cache result wrong of from_unixtime(col, 'yyyy-MM-dd HH:mm:ss') #44631

merged 1 commit into from
Nov 27, 2024

Conversation

924060929
Copy link
Contributor

@924060929 924060929 commented Nov 26, 2024 •
edited
Loading

What problem does this PR solve?

fix sql cache result wrong of from_unixtime(col, 'yyyy-MM-dd HH:mm:ss') which introduced by #33262

the wrong result: is yyyy-MM-dd HH:mm:ss

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929
Copy link
Contributor Author

run buildall

@924060929 924060929 changed the title [fix](sql_cache) fix sql cache result wrong of from_unixtime(col, 'yyyy-MM-dd HH:mm:ss') [fix](nereids) fix sql cache result wrong of from_unixtime(col, 'yyyy-MM-dd HH:mm:ss') Nov 26, 2024
@924060929 924060929 changed the title [fix](nereids) fix sql cache result wrong of from_unixtime(col, 'yyyy-MM-dd HH:mm:ss') [fix](sql_cache) fix sql cache result wrong of from_unixtime(col, 'yyyy-MM-dd HH:mm:ss') Nov 26, 2024
@morrySnow morrySnow added usercase Important user case type label p0_w dev/2.1.x dev/3.0.x labels Nov 26, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 39504 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f4d2b226c7995de1ad14268e67932cb0582b883d, data reload: false

------ Round 1 ----------------------------------
q1	17596	7451	7227	7227
q2	2050	172	165	165
q3	10558	1132	1158	1132
q4	10240	764	679	679
q5	7592	2702	2650	2650
q6	239	147	147	147
q7	993	613	597	597
q8	9232	1823	1898	1823
q9	6531	6417	6350	6350
q10	6967	2313	2365	2313
q11	468	247	249	247
q12	410	210	206	206
q13	17764	2987	3020	2987
q14	238	210	222	210
q15	576	540	518	518
q16	622	579	575	575
q17	979	561	490	490
q18	7334	6836	6777	6777
q19	1331	985	1040	985
q20	492	175	178	175
q21	3885	3197	2940	2940
q22	364	314	311	311
Total cold run time: 106461 ms
Total hot run time: 39504 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7207	7202	7185	7185
q2	319	227	230	227
q3	2868	2776	2933	2776
q4	2092	1797	1751	1751
q5	5585	5694	5648	5648
q6	218	138	137	137
q7	2204	1814	1740	1740
q8	3333	3575	3523	3523
q9	8798	8792	8819	8792
q10	3631	3551	3544	3544
q11	602	508	511	508
q12	809	638	618	618
q13	10309	3196	3159	3159
q14	297	299	275	275
q15	566	531	529	529
q16	669	624	614	614
q17	1775	1572	1554	1554
q18	7759	7424	7364	7364
q19	1649	1524	1377	1377
q20	2025	1790	1795	1790
q21	5230	5134	5166	5134
q22	636	533	556	533
Total cold run time: 68581 ms
Total hot run time: 58778 ms

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-DS: Total hot run time: 190461 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f4d2b226c7995de1ad14268e67932cb0582b883d, data reload: false

query1	969	370	363	363
query2	6524	2037	2029	2029
query3	6701	211	209	209
query4	34425	23443	23613	23443
query5	4322	462	463	462
query6	274	181	192	181
query7	4624	292	312	292
query8	290	234	230	230
query9	9694	2640	2634	2634
query10	478	262	259	259
query11	18443	15101	15126	15101
query12	156	102	103	102
query13	1659	429	403	403
query14	9245	7405	7713	7405
query15	314	176	179	176
query16	8182	441	493	441
query17	1810	587	558	558
query18	2155	301	325	301
query19	375	147	147	147
query20	121	111	112	111
query21	208	102	96	96
query22	4610	4392	4130	4130
query23	34893	33849	34032	33849
query24	11476	2410	2518	2410
query25	707	397	408	397
query26	1797	144	147	144
query27	2869	272	273	272
query28	8132	2427	2439	2427
query29	1025	424	411	411
query30	305	147	149	147
query31	1028	757	779	757
query32	97	54	57	54
query33	778	285	310	285
query34	975	509	513	509
query35	852	732	704	704
query36	1114	925	962	925
query37	285	70	73	70
query38	4363	4285	4198	4198
query39	1462	1420	1420	1420
query40	278	100	99	99
query41	47	43	44	43
query42	109	94	96	94
query43	534	485	481	481
query44	1208	800	795	795
query45	181	165	164	164
query46	1137	688	685	685
query47	1894	1829	1837	1829
query48	422	306	310	306
query49	1284	385	373	373
query50	801	401	383	383
query51	7283	7203	7007	7007
query52	96	93	93	93
query53	260	182	184	182
query54	1265	410	401	401
query55	87	81	76	76
query56	266	237	234	234
query57	1319	1190	1157	1157
query58	269	210	228	210
query59	3283	2902	3032	2902
query60	276	256	256	256
query61	111	128	116	116
query62	861	684	685	684
query63	223	191	187	187
query64	5090	672	631	631
query65	3280	3258	3248	3248
query66	1425	303	312	303
query67	16217	15715	15488	15488
query68	5507	551	559	551
query69	417	261	311	261
query70	1179	1154	1138	1138
query71	341	261	264	261
query72	6307	4117	4004	4004
query73	764	358	347	347
query74	10416	8975	9033	8975
query75	3463	2677	2676	2676
query76	3203	1084	1100	1084
query77	529	268	278	268
query78	10322	9401	9412	9401
query79	2694	612	620	612
query80	1193	435	449	435
query81	548	252	235	235
query82	838	122	119	119
query83	252	153	146	146
query84	235	78	69	69
query85	1426	297	304	297
query86	428	306	301	301
query87	4846	4514	4616	4514
query88	3937	2182	2132	2132
query89	391	303	304	303
query90	2163	183	185	183
query91	139	103	101	101
query92	71	49	50	49
query93	1679	533	548	533
query94	1127	292	295	292
query95	363	257	252	252
query96	609	284	284	284
query97	2889	2684	2710	2684
query98	219	208	200	200
query99	1528	1333	1275	1275
Total cold run time: 307266 ms
Total hot run time: 190461 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.65 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f4d2b226c7995de1ad14268e67932cb0582b883d, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.02	0.04
query3	0.24	0.08	0.07
query4	1.61	0.11	0.10
query5	0.44	0.41	0.38
query6	1.18	0.67	0.64
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.53	0.49
query10	0.56	0.55	0.55
query11	0.13	0.10	0.10
query12	0.13	0.11	0.12
query13	0.61	0.60	0.60
query14	2.72	2.77	2.83
query15	0.91	0.82	0.82
query16	0.39	0.39	0.38
query17	1.03	1.08	1.07
query18	0.23	0.21	0.21
query19	1.96	1.77	1.99
query20	0.02	0.00	0.01
query21	15.36	0.60	0.60
query22	2.62	1.89	1.72
query23	17.24	0.83	0.74
query24	3.06	1.46	0.38
query25	0.26	0.23	0.05
query26	0.43	0.13	0.15
query27	0.07	0.04	0.04
query28	11.23	1.11	1.07
query29	12.57	3.23	3.22
query30	0.25	0.07	0.06
query31	2.87	0.37	0.36
query32	3.30	0.47	0.47
query33	3.00	3.00	3.15
query34	16.76	4.46	4.46
query35	4.50	4.43	4.53
query36	0.68	0.47	0.47
query37	0.09	0.05	0.06
query38	0.04	0.03	0.04
query39	0.03	0.03	0.02
query40	0.16	0.13	0.12
query41	0.09	0.03	0.03
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.56 s
Total hot run time: 31.65 s

@924060929 924060929 merged commit d592e27 into apache:master Nov 27, 2024
31 of 33 checks passed
924060929 added a commit to 924060929/incubator-doris that referenced this pull request Nov 30, 2024
@924060929
[fix](sql_cache) fix sql cache result wrong of from_unixtime(col, 'yy…
7a781c7 
…yy-MM-dd HH:mm:ss') (apache#44631)

fix sql cache result wrong of from_unixtime(col, 'yyyy-MM-dd HH:mm:ss')
which introduced by apache#33262

the wrong result: is `yyyy-MM-dd HH:mm:ss`

(cherry picked from commit d592e27)
@924060929 924060929 mentioned this pull request Nov 30, 2024
Merged
924060929 added a commit to 924060929/incubator-doris that referenced this pull request Nov 30, 2024
@924060929
[fix](sql_cache) fix sql cache result wrong of from_unixtime(col, 'yy…
dc1eec7 
…yy-MM-dd HH:mm:ss') (apache#44631)

fix sql cache result wrong of from_unixtime(col, 'yyyy-MM-dd HH:mm:ss')
which introduced by apache#33262

the wrong result: is `yyyy-MM-dd HH:mm:ss`

(cherry picked from commit d592e27)
@924060929 924060929 mentioned this pull request Nov 30, 2024
Merged
924060929 added a commit that referenced this pull request Dec 2, 2024
@924060929
[fix](sql_cache) fix sql cache result wrong of from_unixtime(col, 'yy…
a8a86f8 
…yy-MM-dd HH:mm:ss') (#44631) (#44810)

fix sql cache result wrong of from_unixtime(col, 'yyyy-MM-dd HH:mm:ss') which introduced by #33262

the wrong result: is `yyyy-MM-dd HH:mm:ss`
924060929 added a commit that referenced this pull request Dec 2, 2024
@924060929
[fix](sql_cache) fix sql cache result wrong of from_unixtime(col, 'yy…
95aacda 
…yy-MM-dd HH:mm:ss') (#44631) (#44811)

fix sql cache result wrong of from_unixtime(col, 'yyyy-MM-dd HH:mm:ss') which introduced by #33262

the wrong result: is `yyyy-MM-dd HH:mm:ss`
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Open
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiBinfeng-01 LiBinfeng-01 LiBinfeng-01 approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged p0_w reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@924060929 @doris-robot @LiBinfeng-01 @morrySnow