Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](s3) do not replace https scheme if specified #44242

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[fix](s3) do not replace https scheme if specified #44242

merged 1 commit into from
Nov 19, 2024

Conversation

morningman
Copy link
Contributor

@morningman morningman commented Nov 19, 2024 •
edited
Loading

What problem does this PR solve?

Problem Summary:
When creating s3 resource with endpoint, if user already specify https:// schema in endpoint url,
we should not replace it with http://.

Release note

fix fix bug that s3 resource do not support https://

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

run buildall

@morningman
Copy link
Contributor Author

run buildall

@morningman morningman mentioned this pull request Nov 19, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 19, 2024
@morningman morningman merged commit def0bc2 into apache:master Nov 19, 2024
29 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
@morningman
[fix](s3) do not replace https scheme if specified (#44242)
5b71b1d 
### What problem does this PR solve?

Problem Summary:
When creating s3 resource with endpoint, it user already specify
`https://` schema in endpoint url,
we should not replace it with `http://`.

### Release note

[fix](s3) fix bug that s3 resource do not support `https://`
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
@morningman
[fix](s3) do not replace https scheme if specified (#44242)
10bddd9 
### What problem does this PR solve?

Problem Summary:
When creating s3 resource with endpoint, it user already specify
`https://` schema in endpoint url,
we should not replace it with `http://`.

### Release note

[fix](s3) fix bug that s3 resource do not support `https://`
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
@wm1581066 wm1581066 added the usercase Important user case type label label Nov 19, 2024
morningman added a commit that referenced this pull request Nov 19, 2024
@github-actions @morningman
branch-2.1: [fix](s3) do not replace https scheme if specified #44242 (…
e937132 
…#44250)

Cherry-picked from #44242

Co-authored-by: Mingyu Chen (Rayner) <[email protected]>
morningman added a commit that referenced this pull request Nov 19, 2024
@github-actions @morningman
branch-3.0: [fix](s3) do not replace https scheme if specified #44242 (…
c149e83 
…#44249)

Cherry-picked from #44242

Co-authored-by: Mingyu Chen (Rayner) <[email protected]>
morningman added a commit that referenced this pull request Nov 19, 2024
@morningman
[fix](s3) do not replace https scheme if specified #44242 (#44243)
a346e77 
cherry-pick #44242
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Open
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@wuwenchi wuwenchi wuwenchi approved these changes

@hubgeter hubgeter hubgeter approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.3-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@morningman @doris-robot @CalvinKirs @wuwenchi @hubgeter @wm1581066