Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](arrayfuncs) fix array_min/array_max func #39307

Merged
merged 6 commits into from
Aug 16, 2024
Merged

[fix](arrayfuncs) fix array_min/array_max func #39307

merged 6 commits into from
Aug 16, 2024

Conversation

amorynan
Copy link
Contributor

Proposed changes

in fe we will check the params same with be
in be we throw exception if params is not support
otherwise we will meet coredump like this

start BE in local mode
/mnt/disk1/wangqiannan/amory/doris/be/src/vec/functions/array/function_array_aggregation.cpp:150:26: runtime error: member call on null pointer of type 'doris::vectorized::IAggregateFunction'
    #0 0x55dc04c6b409 in doris::vectorized::ArrayAggregateImpl<(doris::vectorized::AggregateOperation)1>::get_return_type(std::vector<std::shared_ptr<doris::vectorized::IDataType const>, std::allocator<std::shared_ptr<doris::vectorized::IDataType const>>> const&) /mnt/disk1/wangqiannan/amory/doris/be/src/vec/functions/array/function_array_aggregation.cpp:150:26
    #1 0x55dc04c6a41f in doris::vectorized::FunctionArrayMapped<doris::vectorized::ArrayAggregateImpl<(doris::vectorized::AggregateOperation)1>, doris::vectorized::NameArrayMax>::get_return_type_impl(std::vector<std::shared_ptr<doris::vectorized::IDataType const>, std::allocator<std::shared_ptr<doris::vectorized::IDataType const>>> const&) const /mnt/disk1/wangqiannan/amory/doris/be/src/vec/functions/array/function_array_mapped.h:71:16
    #2 0x55dc049b06cb in doris::vectorized::FunctionBuilderImpl::get_return_type_impl(std::vector<doris::vectorized::ColumnWithTypeAndName, std::allocator<doris::vectorized::ColumnWithTypeAndName>> const&) const /mnt/disk1/wangqiannan/amory/doris/be/src/vec/functions/function.h:339:16
    #3 0x55dc049c1385 in doris::vectorized::DefaultFunctionBuilder::get_return_type_impl(std::vector<doris::vectorized::ColumnWithTypeAndName, std::allocator<doris::vectorized::ColumnWithTypeAndName>> const&) const /mnt/disk1/wangqiannan/amory/doris/be/src/vec/functions/function.h:579:26
    #4 0x55dc0b0a5652 in doris::vectorized::FunctionBuilderImpl::get_return_type_without_low_cardinality(std::vector<doris::vectorized::ColumnWithTypeAndName, std::allocator<doris::vectorized::ColumnWithTypeAndName>> const&) const /mnt/disk1/wangqiannan/amory/doris/be/src/vec/functions/function.cpp:283:12
    #5 0x55dc0b0a5fd4 in doris::vectorized::FunctionBuilderImpl::get_return_type(std::vector<doris::vectorized::ColumnWithTypeAndName, std::allocator<doris::vectorized::ColumnWithTypeAndName>> const&) const /mnt/disk1/wangqiannan/amory/doris/be/src/vec/functions/function.cpp:298:17
    #6 0x55dc04997050 in doris::vectorized::FunctionBuilderImpl::build(std::vector<doris::vectorized::ColumnWithTypeAndName, std::allocator<doris::vectorized::ColumnWithTypeAndName>> const&, std::shared_ptr<doris::vectorized::IDataType const> const&) const /mnt/disk1/wangqiannan/amory/doris/be/src/vec/functions/function.h:296:47
    #7 0x55dbde3d727f in doris::vectorized::SimpleFunctionFactory::get_function(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, std::vector<doris::vectorized::ColumnWithTypeAndName, std::allocator<doris::vectorized::ColumnWithTypeAndName>> const&, std::shared_ptr<doris::vectorized::IDataType const> const&, int) /mnt/disk1/wangqiannan/amory/doris/be/src/vec/functions/simple_function_factory.h:193:32
    #8 0x55dc04984b4d in doris::vectorized::VectorizedFnCall::prepare(doris::RuntimeState*, doris::RowDescriptor const&, doris::vectorized::VExprContext*) /mnt/disk1/wangqiannan/amory/doris/be/src/vec/exprs/vectorized_fn_call.cpp:111:55
    #9 0x55dc04ab9b7a in doris::vectorized::VExprContext::prepare(doris::RuntimeState*, doris::RowDescriptor const&) /mnt/disk1/wangqiannan/amory/doris/be/src/vec/exprs/vexpr_context.cpp:64:5
    #10 0x55dbdf625845 in doris::Status doris::FoldConstantExecutor::_prepare_and_open<doris::vectorized::VExprContext>(doris::vectorized::VExprContext*) /mnt/disk1/wangqiannan/amory/doris/be/src/runtime/fold_constant_executor.cpp:185:5
    #11 0x55dbdf60db76 in doris::FoldConstantExecutor::fold_constant_vexpr(doris::TFoldConstantParams const&, doris::PConstantExprResult*) /mnt/disk1/wangqiannan/amory/doris/be/src/runtime/fold_constant_executor.cpp:94:13
    #12 0x55dbdf4f58d6 in doris::PInternalService::_fold_constant_expr(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, doris::PConstantExprResult*) /mnt/disk1/wangqiannan/amory/doris/be/src/service/internal_service.cpp:1498:5
    #13 0x55dbdf544e3e in doris::PInternalService::fold_constant_expr(google::protobuf::RpcController*, doris::PConstantExprRequest const*, doris::PConstantExprResult*, google::protobuf::Closure*)::$_0::operator()() const /mnt/disk1/wangqiannan/amory/doris/be/src/service/internal_service.cpp:1476:14
    #14 0x55dbdf54431e in void std::__invoke_impl<void, doris::PInternalService::fold_constant_expr(google::protobuf::RpcController*, doris::PConstantExprRequest const*, doris::PConstantExprResult*, google::protobuf::Closure*)::$_0&>(std::__invoke_other, doris::PInternalService::fold_constant_expr(google::protobuf::RpcController*, doris::PConstantExprRequest const*, doris::PConstantExprResult*, google::protobuf::Closure*)::$_0&) /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:61:14
    #15 0x55dbdf54425e in std::enable_if<is_invocable_r_v<void, doris::PInternalService::fold_constant_expr(google::protobuf::RpcController*, doris::PConstantExprRequest const*, doris::PConstantExprResult*, google::protobuf::Closure*)::$_0&>, void>::type std::__invoke_r<void, doris::PInternalService::fold_constant_expr(google::protobuf::RpcController*, doris::PConstantExprRequest const*, doris::PConstantExprResult*, google::protobuf::Closure*)::$_0&>(doris::PInternalService::fold_constant_expr(google::protobuf::RpcController*, doris::PConstantExprRequest const*, doris::PConstantExprResult*, google::protobuf::Closure*)::$_0&) /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:111:2
    #16 0x55dbdf543f35 in std::_Function_handler<void (), doris::PInternalService::fold_constant_expr(google::protobuf::RpcController*, doris::PConstantExprRequest const*, doris::PConstantExprResult*, google::protobuf::Closure*)::$_0>::_M_invoke(std::_Any_data const&) /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291:9
    #17 0x55dbd8cd425a in std::function<void ()>::operator()() const /mnt/disk1/wangqiannan/tool/ldb_toolchain_16/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:560:9
    #18 0x55dbdf59ee14 in doris::WorkThreadPool<false>::work_thread(int) /mnt/disk1/wangqiannan/amory/doris/be/src/util/work_thread_pool.hpp:158:17
@@@

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@amorynan
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the doing label Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39716 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 90330c904ad7188fb434b4d8d0c9bf20820d3f54, data reload: false

------ Round 1 ----------------------------------
q1	17620	4437	4248	4248
q2	2026	175	186	175
q3	10489	1133	1169	1133
q4	10162	773	695	695
q5	7835	2852	2805	2805
q6	226	138	140	138
q7	989	602	611	602
q8	9409	2016	2033	2016
q9	8757	6595	6536	6536
q10	7046	2207	2213	2207
q11	469	250	253	250
q12	397	223	223	223
q13	17768	2993	2978	2978
q14	278	252	243	243
q15	511	473	479	473
q16	513	393	378	378
q17	968	762	691	691
q18	8138	7542	7396	7396
q19	5972	1071	1037	1037
q20	683	338	331	331
q21	5281	4436	4178	4178
q22	1115	995	983	983
Total cold run time: 116652 ms
Total hot run time: 39716 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4437	4251	4272	4251
q2	378	273	270	270
q3	2823	2642	2611	2611
q4	1872	1634	1653	1634
q5	5400	5393	5375	5375
q6	218	132	128	128
q7	2039	1654	1676	1654
q8	3152	3318	3300	3300
q9	8332	8352	8317	8317
q10	3412	3144	3145	3144
q11	633	505	499	499
q12	779	613	612	612
q13	17540	2989	3006	2989
q14	315	268	282	268
q15	516	481	476	476
q16	468	437	433	433
q17	1757	1443	1483	1443
q18	7676	7484	7364	7364
q19	1670	1563	1483	1483
q20	2013	1802	1759	1759
q21	5413	5222	5062	5062
q22	1069	974	1013	974
Total cold run time: 71912 ms
Total hot run time: 54046 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186502 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 90330c904ad7188fb434b4d8d0c9bf20820d3f54, data reload: false

query1	911	375	376	375
query2	6465	1956	1850	1850
query3	6654	226	214	214
query4	33713	23351	23206	23206
query5	4189	485	493	485
query6	263	174	167	167
query7	4591	297	298	297
query8	261	205	199	199
query9	8554	2469	2430	2430
query10	430	268	267	267
query11	17754	15010	15047	15010
query12	146	103	102	102
query13	1625	379	374	374
query14	9925	7537	7621	7537
query15	214	173	168	168
query16	7783	477	482	477
query17	1578	580	557	557
query18	1999	291	313	291
query19	206	151	153	151
query20	115	115	112	112
query21	208	107	99	99
query22	4242	3957	3938	3938
query23	33915	33699	33234	33234
query24	12078	2811	2793	2793
query25	686	406	409	406
query26	1612	160	159	159
query27	2793	274	275	274
query28	7219	2056	2039	2039
query29	1049	442	427	427
query30	309	148	150	148
query31	978	765	761	761
query32	97	56	58	56
query33	766	322	296	296
query34	927	470	472	470
query35	834	722	736	722
query36	1108	919	923	919
query37	152	82	83	82
query38	3995	3781	3841	3781
query39	1435	1399	1410	1399
query40	270	119	118	118
query41	52	47	47	47
query42	119	100	99	99
query43	524	461	483	461
query44	1254	738	745	738
query45	199	166	165	165
query46	1120	721	729	721
query47	1856	1802	1801	1801
query48	373	294	294	294
query49	1152	426	434	426
query50	817	415	409	409
query51	6843	6718	6675	6675
query52	107	91	98	91
query53	261	195	187	187
query54	1036	464	460	460
query55	77	79	75	75
query56	285	268	272	268
query57	1152	1065	1075	1065
query58	254	225	241	225
query59	3040	2877	2856	2856
query60	304	274	276	274
query61	120	227	100	100
query62	855	665	656	656
query63	209	177	180	177
query64	10631	2335	1788	1788
query65	3230	3115	3128	3115
query66	1393	355	349	349
query67	15584	14898	14836	14836
query68	8556	558	563	558
query69	701	405	307	307
query70	1147	1113	1092	1092
query71	524	273	305	273
query72	7964	2257	2083	2083
query73	1286	331	330	330
query74	9597	8813	8812	8812
query75	5158	2695	2699	2695
query76	5107	973	1023	973
query77	782	315	308	308
query78	9744	9108	9650	9108
query79	8240	528	536	528
query80	2367	495	494	494
query81	582	224	224	224
query82	764	133	135	133
query83	295	149	143	143
query84	263	78	77	77
query85	1404	284	307	284
query86	392	289	297	289
query87	4375	4191	4244	4191
query88	4964	2437	2437	2437
query89	500	284	283	283
query90	2050	205	199	199
query91	122	96	94	94
query92	60	52	49	49
query93	6433	539	534	534
query94	956	285	295	285
query95	362	258	263	258
query96	621	272	273	272
query97	3221	3070	3019	3019
query98	227	199	196	196
query99	1546	1290	1226	1226
Total cold run time: 325206 ms
Total hot run time: 186502 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.45 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 90330c904ad7188fb434b4d8d0c9bf20820d3f54, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.08	0.08
query5	0.50	0.48	0.48
query6	1.14	0.74	0.74
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.50	0.48
query10	0.54	0.54	0.55
query11	0.15	0.12	0.12
query12	0.14	0.12	0.12
query13	0.60	0.61	0.59
query14	0.76	0.79	0.77
query15	0.88	0.82	0.82
query16	0.37	0.36	0.36
query17	1.01	1.02	1.02
query18	0.22	0.22	0.22
query19	1.84	1.72	1.71
query20	0.02	0.01	0.01
query21	15.44	0.76	0.66
query22	4.66	7.79	1.60
query23	18.24	1.37	1.24
query24	2.09	0.24	0.22
query25	0.15	0.08	0.07
query26	0.30	0.21	0.21
query27	0.46	0.23	0.23
query28	13.31	1.01	1.00
query29	12.66	3.31	3.31
query30	0.23	0.05	0.04
query31	2.89	0.41	0.40
query32	3.24	0.50	0.47
query33	2.91	2.92	2.97
query34	17.04	4.36	4.37
query35	4.43	4.42	4.44
query36	0.65	0.48	0.47
query37	0.18	0.15	0.16
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.15	0.13	0.12
query41	0.09	0.04	0.04
query42	0.05	0.06	0.05
query43	0.05	0.05	0.04
Total cold run time: 110.23 s
Total hot run time: 30.45 s

@wm1581066 wm1581066 added p0_c usercase Important user case type label dev/2.1.x labels Aug 13, 2024
@amorynan
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40291 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d200ddec8c7bd450a144dc71c19d68f4d1c4611c, data reload: false

------ Round 1 ----------------------------------
q1	18169	4486	4346	4346
q2	2855	187	179	179
q3	11105	1163	1097	1097
q4	10514	786	723	723
q5	8655	2829	2827	2827
q6	226	139	137	137
q7	991	604	603	603
q8	9544	2028	2027	2027
q9	8793	6566	6596	6566
q10	7024	2211	2172	2172
q11	458	246	249	246
q12	395	222	223	222
q13	17828	2981	2970	2970
q14	293	231	234	231
q15	532	468	494	468
q16	503	384	392	384
q17	954	723	772	723
q18	8153	7593	7413	7413
q19	6100	1079	1032	1032
q20	699	331	330	330
q21	5377	4611	4757	4611
q22	1115	1013	984	984
Total cold run time: 120283 ms
Total hot run time: 40291 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4433	4304	4242	4242
q2	375	264	269	264
q3	2834	2612	2611	2611
q4	1904	1622	1616	1616
q5	5348	5397	5345	5345
q6	222	130	135	130
q7	2068	1663	1670	1663
q8	3141	3320	3322	3320
q9	8349	8353	8369	8353
q10	3418	3181	3159	3159
q11	584	495	492	492
q12	775	588	580	580
q13	16505	3008	2994	2994
q14	305	280	255	255
q15	522	474	471	471
q16	462	424	418	418
q17	1774	1486	1469	1469
q18	7641	7720	7688	7688
q19	1662	1639	1544	1544
q20	2011	1791	1809	1791
q21	5173	5233	5078	5078
q22	1102	1031	1012	1012
Total cold run time: 70608 ms
Total hot run time: 54495 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185730 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d200ddec8c7bd450a144dc71c19d68f4d1c4611c, data reload: false

query1	912	371	385	371
query2	6455	1952	1974	1952
query3	6662	210	215	210
query4	33992	23262	23384	23262
query5	4218	483	496	483
query6	298	172	161	161
query7	4587	295	288	288
query8	251	201	197	197
query9	8492	2447	2417	2417
query10	439	287	263	263
query11	17949	14997	15073	14997
query12	146	101	104	101
query13	1632	377	365	365
query14	9817	7156	7890	7156
query15	231	170	168	168
query16	7765	491	467	467
query17	1557	554	529	529
query18	1977	290	283	283
query19	195	139	139	139
query20	110	104	103	103
query21	204	100	101	100
query22	4513	4207	4188	4188
query23	33864	33272	33324	33272
query24	12220	2835	2864	2835
query25	666	373	371	371
query26	1785	157	153	153
query27	2808	271	273	271
query28	7594	2031	2045	2031
query29	1124	406	397	397
query30	314	152	144	144
query31	957	740	756	740
query32	98	54	55	54
query33	755	280	276	276
query34	965	459	465	459
query35	856	737	685	685
query36	1085	895	929	895
query37	282	78	82	78
query38	3893	3783	3723	3723
query39	1442	1383	1364	1364
query40	273	115	117	115
query41	46	44	44	44
query42	123	96	96	96
query43	512	478	471	471
query44	1181	734	743	734
query45	217	160	167	160
query46	1126	769	769	769
query47	1854	1778	1795	1778
query48	374	286	289	286
query49	1193	411	411	411
query50	799	403	399	399
query51	6771	6752	6651	6651
query52	99	90	92	90
query53	252	186	178	178
query54	985	445	439	439
query55	75	74	74	74
query56	264	255	246	246
query57	1159	1083	1045	1045
query58	249	212	226	212
query59	2968	2816	2788	2788
query60	295	298	262	262
query61	97	93	98	93
query62	825	660	622	622
query63	214	184	189	184
query64	10586	2342	1751	1751
query65	3298	3142	3211	3142
query66	1376	329	334	329
query67	15456	15004	14937	14937
query68	4582	544	540	540
query69	403	274	268	268
query70	1179	1061	1128	1061
query71	374	274	268	268
query72	7118	2290	2035	2035
query73	759	324	327	324
query74	9125	8766	8831	8766
query75	3464	2697	2752	2697
query76	2835	1075	935	935
query77	489	313	309	309
query78	9806	9100	9702	9100
query79	2862	527	526	526
query80	1947	503	550	503
query81	577	229	220	220
query82	879	138	133	133
query83	269	160	148	148
query84	277	79	87	79
query85	2068	266	270	266
query86	313	295	296	295
query87	4296	4131	4253	4131
query88	4196	2397	2391	2391
query89	396	287	309	287
query90	1509	201	187	187
query91	161	97	97	97
query92	57	49	51	49
query93	2587	526	526	526
query94	584	301	290	290
query95	347	253	260	253
query96	605	275	269	269
query97	3182	3044	3044	3044
query98	225	203	217	203
query99	1611	1276	1316	1276
Total cold run time: 304859 ms
Total hot run time: 185730 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.59 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d200ddec8c7bd450a144dc71c19d68f4d1c4611c, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.04	0.04
query3	0.22	0.05	0.06
query4	1.66	0.10	0.09
query5	0.50	0.51	0.50
query6	1.13	0.73	0.72
query7	0.02	0.01	0.02
query8	0.04	0.04	0.05
query9	0.55	0.47	0.48
query10	0.54	0.54	0.54
query11	0.16	0.12	0.12
query12	0.15	0.13	0.13
query13	0.61	0.62	0.60
query14	0.76	0.78	0.79
query15	0.86	0.82	0.81
query16	0.36	0.37	0.38
query17	0.99	1.04	1.04
query18	0.22	0.22	0.21
query19	1.89	1.86	1.72
query20	0.00	0.03	0.01
query21	15.41	0.76	0.66
query22	4.18	7.67	1.68
query23	18.26	1.42	1.28
query24	2.10	0.22	0.23
query25	0.14	0.08	0.08
query26	0.31	0.22	0.21
query27	0.45	0.23	0.21
query28	13.27	1.03	0.99
query29	12.63	3.34	3.28
query30	0.24	0.04	0.04
query31	2.91	0.39	0.39
query32	3.26	0.49	0.47
query33	2.92	2.99	2.97
query34	17.02	4.36	4.32
query35	4.42	4.44	4.44
query36	0.65	0.48	0.49
query37	0.18	0.15	0.16
query38	0.15	0.14	0.15
query39	0.05	0.04	0.04
query40	0.17	0.14	0.13
query41	0.09	0.04	0.04
query42	0.06	0.05	0.04
query43	0.04	0.05	0.04
Total cold run time: 109.69 s
Total hot run time: 30.59 s

@amorynan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 37852 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6e1356abc27105cc05d02b5981de0c97f1db3a0d, data reload: false

------ Round 1 ----------------------------------
q1	18101	4484	4348	4348
q2	2678	181	180	180
q3	11458	1150	1140	1140
q4	10697	718	657	657
q5	7803	2860	2829	2829
q6	250	145	143	143
q7	978	592	598	592
q8	9327	2009	2014	2009
q9	7267	6517	6512	6512
q10	7012	2263	2168	2168
q11	467	250	249	249
q12	385	221	218	218
q13	17765	2983	2981	2981
q14	285	241	238	238
q15	519	494	488	488
q16	502	384	388	384
q17	957	710	776	710
q18	7398	6815	6816	6815
q19	3181	1078	1018	1018
q20	668	320	337	320
q21	4656	2979	2867	2867
q22	1111	986	1001	986
Total cold run time: 113465 ms
Total hot run time: 37852 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4354	4223	4245	4223
q2	369	279	275	275
q3	2877	2614	2604	2604
q4	1879	1615	1636	1615
q5	5331	5352	5330	5330
q6	221	133	137	133
q7	2031	1671	1683	1671
q8	3143	3305	3278	3278
q9	8401	8380	8332	8332
q10	3385	3149	3218	3149
q11	581	506	514	506
q12	773	614	626	614
q13	16523	3018	2975	2975
q14	311	276	296	276
q15	521	483	484	483
q16	485	421	432	421
q17	1774	1476	1487	1476
q18	7749	7562	7395	7395
q19	2737	1609	1568	1568
q20	2005	1796	1815	1796
q21	5219	5167	5064	5064
q22	1089	1029	1011	1011
Total cold run time: 71758 ms
Total hot run time: 54195 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185524 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6e1356abc27105cc05d02b5981de0c97f1db3a0d, data reload: false

query1	907	377	372	372
query2	6455	1910	1840	1840
query3	6647	207	216	207
query4	33427	23144	23045	23045
query5	4198	489	503	489
query6	275	158	172	158
query7	4587	299	286	286
query8	251	197	196	196
query9	8513	2437	2414	2414
query10	436	275	272	272
query11	15593	14909	15076	14909
query12	152	101	101	101
query13	1631	368	370	368
query14	9594	7006	7183	7006
query15	225	175	172	172
query16	7735	510	500	500
query17	1556	592	547	547
query18	1987	288	292	288
query19	189	143	145	143
query20	113	108	104	104
query21	209	101	102	101
query22	4408	4297	3944	3944
query23	33906	33394	33357	33357
query24	12093	2853	2843	2843
query25	709	389	401	389
query26	1780	160	156	156
query27	2775	273	277	273
query28	7533	2041	2040	2040
query29	1135	419	415	415
query30	314	146	150	146
query31	971	761	757	757
query32	96	58	56	56
query33	751	292	290	290
query34	942	479	469	469
query35	859	737	715	715
query36	1060	915	951	915
query37	162	84	85	84
query38	3968	3846	3907	3846
query39	1452	1373	1391	1373
query40	272	117	119	117
query41	49	47	46	46
query42	123	97	100	97
query43	501	460	473	460
query44	1271	735	746	735
query45	195	165	164	164
query46	1131	721	739	721
query47	1827	1765	1791	1765
query48	366	293	293	293
query49	1164	434	429	429
query50	813	400	404	400
query51	6814	6715	6605	6605
query52	102	92	98	92
query53	255	189	187	187
query54	1027	461	444	444
query55	76	77	79	77
query56	282	268	259	259
query57	1156	1094	1067	1067
query58	245	236	229	229
query59	2967	3076	2946	2946
query60	306	269	273	269
query61	117	114	113	113
query62	948	673	628	628
query63	210	191	185	185
query64	6293	2269	1737	1737
query65	3251	3144	3123	3123
query66	1375	340	355	340
query67	15458	14978	14902	14902
query68	8634	544	551	544
query69	675	385	305	305
query70	1103	1086	1132	1086
query71	529	272	271	271
query72	7603	2229	2078	2078
query73	1172	318	313	313
query74	9389	8793	8721	8721
query75	4950	2673	2723	2673
query76	5151	996	968	968
query77	813	324	317	317
query78	11479	9704	9029	9029
query79	11953	551	545	545
query80	1353	506	499	499
query81	587	223	222	222
query82	458	134	131	131
query83	333	148	144	144
query84	264	76	76	76
query85	741	281	264	264
query86	398	303	303	303
query87	4333	4286	4325	4286
query88	5318	2315	2372	2315
query89	431	289	289	289
query90	2049	200	200	200
query91	123	98	98	98
query92	62	54	50	50
query93	4909	525	524	524
query94	942	297	272	272
query95	346	260	258	258
query96	598	269	270	269
query97	3238	3040	3037	3037
query98	227	202	200	200
query99	1505	1221	1263	1221
Total cold run time: 319854 ms
Total hot run time: 185524 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.04 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6e1356abc27105cc05d02b5981de0c97f1db3a0d, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.65	0.08	0.09
query5	0.51	0.50	0.49
query6	1.13	0.75	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.53	0.48	0.49
query10	0.53	0.53	0.54
query11	0.15	0.12	0.11
query12	0.15	0.12	0.12
query13	0.60	0.60	0.60
query14	0.76	0.78	0.78
query15	0.87	0.82	0.82
query16	0.36	0.37	0.37
query17	1.00	1.01	0.99
query18	0.23	0.22	0.21
query19	1.77	1.69	1.73
query20	0.03	0.01	0.02
query21	15.39	0.74	0.65
query22	4.00	6.91	2.12
query23	18.30	1.36	1.30
query24	2.12	0.21	0.23
query25	0.15	0.08	0.08
query26	0.31	0.22	0.21
query27	0.45	0.25	0.22
query28	13.29	1.02	1.01
query29	12.60	3.44	3.40
query30	0.24	0.05	0.05
query31	2.89	0.38	0.38
query32	3.29	0.48	0.49
query33	2.96	3.00	2.98
query34	17.06	4.33	4.36
query35	4.44	4.42	4.39
query36	0.66	0.48	0.46
query37	0.19	0.16	0.15
query38	0.16	0.14	0.15
query39	0.04	0.03	0.04
query40	0.15	0.13	0.13
query41	0.09	0.05	0.05
query42	0.06	0.04	0.04
query43	0.05	0.04	0.04
Total cold run time: 109.58 s
Total hot run time: 31.04 s

@amorynan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 37782 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 422e4f220ba47f55a1596fc3f7bbadd4af4bca1e, data reload: false

------ Round 1 ----------------------------------
q1	17638	4400	4266	4266
q2	2021	174	171	171
q3	11605	1051	1121	1051
q4	10526	677	754	677
q5	7744	2818	2811	2811
q6	221	133	134	133
q7	965	599	603	599
q8	9627	2048	2077	2048
q9	7331	6592	6543	6543
q10	7063	2215	2199	2199
q11	476	236	243	236
q12	398	218	219	218
q13	19085	3001	2985	2985
q14	283	243	249	243
q15	542	504	538	504
q16	598	397	378	378
q17	973	676	689	676
q18	7451	6864	6683	6683
q19	6579	1029	988	988
q20	734	332	352	332
q21	3827	2976	3028	2976
q22	1167	1065	1092	1065
Total cold run time: 116854 ms
Total hot run time: 37782 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5509	4433	4324	4324
q2	381	266	270	266
q3	3000	2819	2879	2819
q4	2022	1750	1750	1750
q5	5681	5772	5684	5684
q6	227	132	129	129
q7	2143	1763	1787	1763
q8	3330	3488	3441	3441
q9	8796	8729	8945	8729
q10	3538	3253	3351	3253
q11	573	487	497	487
q12	773	620	622	620
q13	16932	3220	3155	3155
q14	319	289	276	276
q15	540	486	470	470
q16	513	436	431	431
q17	1847	1529	1535	1529
q18	8054	8102	7869	7869
q19	1716	1639	1649	1639
q20	2101	1934	1921	1921
q21	8976	5317	4996	4996
q22	1060	1044	1012	1012
Total cold run time: 78031 ms
Total hot run time: 56563 ms

@amorynan
Copy link
Contributor Author

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 37246 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 422e4f220ba47f55a1596fc3f7bbadd4af4bca1e, data reload: false

------ Round 1 ----------------------------------
q1	17861	4308	4268	4268
q2	2017	173	171	171
q3	10527	1198	1082	1082
q4	10147	805	738	738
q5	7746	2806	2742	2742
q6	222	146	137	137
q7	962	610	580	580
q8	9302	2021	1993	1993
q9	7258	6524	6527	6524
q10	7041	2223	2156	2156
q11	457	236	246	236
q12	385	221	218	218
q13	18879	3093	3089	3089
q14	286	243	240	240
q15	523	476	496	476
q16	516	400	414	400
q17	983	670	755	670
q18	7460	6852	6656	6656
q19	6270	973	1009	973
q20	697	325	331	325
q21	3775	2773	2588	2588
q22	1086	1016	984	984
Total cold run time: 114400 ms
Total hot run time: 37246 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4417	4257	4254	4254
q2	389	266	263	263
q3	2815	2607	2540	2540
q4	1842	1589	1551	1551
q5	5392	5557	5626	5557
q6	226	135	133	133
q7	2151	1779	1720	1720
q8	3250	3378	3376	3376
q9	8680	8729	8907	8729
q10	3521	3274	3281	3274
q11	597	507	515	507
q12	807	646	593	593
q13	17474	3057	3211	3057
q14	323	284	293	284
q15	517	499	495	495
q16	479	426	431	426
q17	1790	1480	1512	1480
q18	8065	7880	7325	7325
q19	1651	1526	1623	1526
q20	2238	1798	1800	1798
q21	5146	5083	4944	4944
q22	1105	1015	1016	1015
Total cold run time: 72875 ms
Total hot run time: 54847 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184538 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 422e4f220ba47f55a1596fc3f7bbadd4af4bca1e, data reload: false

query1	889	363	377	363
query2	6463	1896	1815	1815
query3	6651	212	218	212
query4	25239	23185	23198	23185
query5	4179	488	482	482
query6	250	162	165	162
query7	4602	305	289	289
query8	242	200	194	194
query9	8380	2417	2410	2410
query10	425	267	263	263
query11	17719	14896	14960	14896
query12	147	103	103	103
query13	1635	372	368	368
query14	11039	6919	6961	6919
query15	248	162	169	162
query16	7895	516	478	478
query17	1534	572	551	551
query18	1424	296	291	291
query19	202	148	147	147
query20	117	106	107	106
query21	212	101	96	96
query22	4180	4113	3905	3905
query23	33885	33142	33332	33142
query24	11460	2892	2876	2876
query25	636	399	401	399
query26	1522	155	160	155
query27	2865	277	274	274
query28	7689	2034	2009	2009
query29	937	422	426	422
query30	308	155	153	153
query31	990	761	777	761
query32	98	54	57	54
query33	754	291	286	286
query34	920	473	462	462
query35	868	744	709	709
query36	1090	931	944	931
query37	153	81	82	81
query38	3999	3886	3886	3886
query39	1439	1432	1379	1379
query40	276	118	202	118
query41	46	43	44	43
query42	115	97	101	97
query43	492	462	447	447
query44	1233	730	723	723
query45	193	161	160	160
query46	1105	731	726	726
query47	1856	1758	1752	1752
query48	358	295	294	294
query49	1154	407	406	406
query50	793	398	408	398
query51	6762	6722	6670	6670
query52	95	96	90	90
query53	255	181	191	181
query54	945	439	441	439
query55	76	74	72	72
query56	284	238	235	235
query57	1141	1053	1037	1037
query58	224	225	217	217
query59	2921	2788	2694	2694
query60	298	262	281	262
query61	100	92	96	92
query62	817	640	678	640
query63	222	179	176	176
query64	6294	2236	1692	1692
query65	3177	3107	3151	3107
query66	1237	339	335	335
query67	15378	14852	14876	14852
query68	6549	554	555	554
query69	660	375	351	351
query70	1199	1103	1118	1103
query71	489	282	275	275
query72	7529	2284	2008	2008
query73	806	315	321	315
query74	9028	8784	8696	8696
query75	4599	2635	2663	2635
query76	4254	1020	996	996
query77	726	317	307	307
query78	9680	9128	8897	8897
query79	3950	520	520	520
query80	2396	501	493	493
query81	595	222	226	222
query82	1401	136	140	136
query83	287	153	155	153
query84	265	77	78	77
query85	1476	278	266	266
query86	442	301	295	295
query87	4368	4203	4248	4203
query88	4888	2314	2312	2312
query89	454	287	281	281
query90	2027	203	234	203
query91	122	94	97	94
query92	61	50	48	48
query93	5030	529	527	527
query94	1054	292	279	279
query95	349	254	253	253
query96	622	274	274	274
query97	3148	3011	3078	3011
query98	234	200	199	199
query99	1623	1224	1281	1224
Total cold run time: 301443 ms
Total hot run time: 184538 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.86 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 422e4f220ba47f55a1596fc3f7bbadd4af4bca1e, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.04
query4	1.69	0.08	0.10
query5	0.51	0.52	0.50
query6	1.12	0.73	0.72
query7	0.02	0.01	0.02
query8	0.05	0.05	0.05
query9	0.55	0.50	0.49
query10	0.55	0.54	0.54
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.59	0.61	0.58
query14	0.77	0.77	0.82
query15	0.85	0.81	0.81
query16	0.37	0.37	0.38
query17	1.03	1.04	1.05
query18	0.23	0.21	0.21
query19	1.80	1.71	1.72
query20	0.01	0.00	0.01
query21	15.39	0.74	0.65
query22	3.67	7.29	2.97
query23	18.28	1.35	1.24
query24	2.21	0.23	0.22
query25	0.16	0.07	0.08
query26	0.31	0.22	0.21
query27	0.46	0.23	0.23
query28	13.22	1.03	0.99
query29	12.56	3.45	3.38
query30	0.23	0.05	0.04
query31	2.91	0.39	0.40
query32	3.24	0.50	0.48
query33	2.96	2.98	2.94
query34	17.20	4.36	4.40
query35	4.38	4.39	4.42
query36	0.66	0.48	0.49
query37	0.20	0.16	0.16
query38	0.17	0.15	0.14
query39	0.05	0.03	0.03
query40	0.15	0.12	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.04
query43	0.05	0.05	0.04
Total cold run time: 109.42 s
Total hot run time: 31.86 s

@amorynan
Copy link
Contributor Author

run feut

@amorynan
Copy link
Contributor Author

run cloud_p1

1 similar comment
@amorynan
Copy link
Contributor Author

run cloud_p1

HappenLee
HappenLee approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

eldenmoon
eldenmoon approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit 3ab85f3 into apache:master Aug 16, 2024
30 of 34 checks passed
This was referenced Aug 16, 2024
Merged
Merged
xiaokang pushed a commit that referenced this pull request Aug 17, 2024
@amorynan
[fix](array-funcs) array min/max #39307 (#39484)
79aa079
xiaokang pushed a commit that referenced this pull request Aug 17, 2024
@amorynan
[fix](array) fix array min/max #39307 (#39492)
22fc0bd
@xiaokang xiaokang changed the title [fix](arrayfuncs) fix array min/max func [fix](arrayfuncs) fix array_min/array_max func Aug 20, 2024
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HappenLee HappenLee HappenLee approved these changes

@eldenmoon eldenmoon eldenmoon approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged p0_c reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@amorynan @doris-robot @HappenLee @eldenmoon @xiaokang @wm1581066 @dataroaring