-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat](nereids) add max/min filter push down rewrite rule #39252
Merged
morrySnow
merged 9 commits into
apache:master
from
feiniaofeiafei:min_max_filter_rewrite
Sep 4, 2024
Merged
[Feat](nereids) add max/min filter push down rewrite rule #39252
morrySnow
merged 9 commits into
apache:master
from
feiniaofeiafei:min_max_filter_rewrite
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 39325 ms
|
TPC-DS: Total hot run time: 200590 ms
|
ClickBench: Total hot run time: 30.9 s
|
run buildall |
1 similar comment
run buildall |
TPC-H: Total hot run time: 39941 ms
|
b0a1a8e
to
5aa3d54
Compare
run buildall |
TPC-H: Total hot run time: 37433 ms
|
TPC-DS: Total hot run time: 189978 ms
|
ClickBench: Total hot run time: 31.12 s
|
45435a6
to
2dcaaee
Compare
run buildall |
TPC-H: Total hot run time: 37800 ms
|
TPC-DS: Total hot run time: 183901 ms
|
ClickBench: Total hot run time: 30.93 s
|
2dcaaee
to
3f961c4
Compare
run buildall |
TPC-H: Total hot run time: 38674 ms
|
TPC-DS: Total hot run time: 191361 ms
|
ClickBench: Total hot run time: 31.6 s
|
run cloud_p1 |
morrySnow
reviewed
Aug 20, 2024
fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/MaxMinFilterPushDownTest.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/MaxMinFilterPushDownTest.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/MaxMinFilterPushDown.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/MaxMinFilterPushDown.java
Outdated
Show resolved
Hide resolved
4f69ba3
to
3b81ab7
Compare
run buildall |
1 similar comment
run buildall |
TPC-H: Total hot run time: 37943 ms
|
TPC-DS: Total hot run time: 187984 ms
|
ClickBench: Total hot run time: 32.13 s
|
bde263e
to
879f12f
Compare
run buildall |
TPC-H: Total hot run time: 38017 ms
|
TPC-DS: Total hot run time: 192463 ms
|
ClickBench: Total hot run time: 32.53 s
|
morrySnow
approved these changes
Sep 4, 2024
feiniaofeiafei
added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Oct 15, 2024
add rewrite rule: select id, max(a) from t group by id having max(a)>10; -> select id, max(a) from t where a>10 group by id; select id, min(a) from t group by id having min(a)<10; -> select id, min(a) from t where a<10 group by id;
924060929
pushed a commit
that referenced
this pull request
Oct 24, 2024
…41907) add rewrite rule: select id, max(a) from t group by id having max(a)>10; -> select id, max(a) from t where a>10 group by id; select id, min(a) from t group by id having min(a)<10; -> select id, min(a) from t where a<10 group by id;
feiniaofeiafei
added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Nov 12, 2024
add rewrite rule: select id, max(a) from t group by id having max(a)>10; -> select id, max(a) from t where a>10 group by id; select id, min(a) from t group by id having min(a)<10; -> select id, min(a) from t where a<10 group by id;
yiguolei
pushed a commit
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.1.8-merged
dev/3.0.3-merged
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add rewrite rule:
select id, max(a) from t group by id having max(a)>10;
->
select id, max(a) from t where a>10 group by id;
select id, min(a) from t group by id having min(a)<10;
->
select id, min(a) from t where a<10 group by id;