Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](mtmv)Mtmv support row column #35860

Merged
merged 11 commits into from
Jun 5, 2024
Merged

[fix](mtmv)Mtmv support row column #35860

merged 11 commits into from
Jun 5, 2024

Conversation

zddr
Copy link
Contributor

@zddr zddr commented Jun 4, 2024

when create mtmv with property 'store_row_column' = 'true',and select * from mtmv order by xxx limit xxx
be will core,before MTMV not have hidden column __DORIS_ROW_STORE_COL__

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zddr
Copy link
Contributor Author

zddr commented Jun 4, 2024

run buildall

@zddr
Copy link
Contributor Author

zddr commented Jun 4, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39993 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 065f7118bbeb31fabd80b97245d14b6ffc9891d5, data reload: false

------ Round 1 ----------------------------------
q1	17890	4459	4269	4269
q2	2029	192	197	192
q3	10553	1205	1163	1163
q4	10831	789	766	766
q5	7485	2734	2656	2656
q6	224	136	138	136
q7	973	611	602	602
q8	9309	2092	2119	2092
q9	9175	6605	6621	6605
q10	9367	3713	3694	3694
q11	465	250	235	235
q12	491	225	229	225
q13	17767	2974	2976	2974
q14	255	217	223	217
q15	501	465	468	465
q16	521	388	383	383
q17	977	652	646	646
q18	8018	7439	7366	7366
q19	5694	1501	1463	1463
q20	658	307	305	305
q21	4912	3938	3201	3201
q22	400	338	342	338
Total cold run time: 118495 ms
Total hot run time: 39993 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4353	4251	4234	4234
q2	385	269	268	268
q3	2963	2715	2759	2715
q4	1846	1562	1608	1562
q5	5248	5276	5297	5276
q6	214	128	128	128
q7	2166	1774	1733	1733
q8	3242	3349	3320	3320
q9	8316	8300	8358	8300
q10	3838	3674	3649	3649
q11	583	479	518	479
q12	768	615	577	577
q13	16611	2958	2974	2958
q14	311	267	284	267
q15	515	477	485	477
q16	465	417	413	413
q17	1793	1501	1469	1469
q18	7642	7574	7389	7389
q19	1717	1517	1597	1517
q20	1978	1798	1801	1798
q21	5462	4735	4823	4735
q22	618	551	567	551
Total cold run time: 71034 ms
Total hot run time: 53815 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172018 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 065f7118bbeb31fabd80b97245d14b6ffc9891d5, data reload: false

query1	926	376	365	365
query2	6448	2448	2421	2421
query3	6643	225	218	218
query4	19753	17160	17288	17160
query5	4104	457	457	457
query6	247	163	156	156
query7	4587	303	297	297
query8	318	300	284	284
query9	8509	2469	2481	2469
query10	449	288	285	285
query11	10517	10197	9985	9985
query12	141	86	87	86
query13	1638	365	361	361
query14	9976	6769	6483	6483
query15	234	189	192	189
query16	7792	291	283	283
query17	1566	520	518	518
query18	1850	272	265	265
query19	205	149	152	149
query20	92	88	84	84
query21	215	141	127	127
query22	4399	4148	3921	3921
query23	33850	33064	33200	33064
query24	12196	2811	2799	2799
query25	655	346	360	346
query26	1781	154	161	154
query27	2967	339	343	339
query28	7177	2116	2130	2116
query29	1098	634	601	601
query30	275	146	150	146
query31	945	750	757	750
query32	94	51	55	51
query33	763	286	274	274
query34	967	471	477	471
query35	778	624	613	613
query36	1078	934	941	934
query37	297	67	69	67
query38	2891	2725	2741	2725
query39	901	811	794	794
query40	282	127	122	122
query41	54	53	53	53
query42	120	98	94	94
query43	604	596	561	561
query44	1192	720	756	720
query45	196	176	171	171
query46	1068	717	718	717
query47	1850	1772	1780	1772
query48	376	299	296	296
query49	1198	399	412	399
query50	764	395	383	383
query51	6899	6784	6791	6784
query52	107	100	86	86
query53	349	289	289	289
query54	980	452	450	450
query55	75	74	77	74
query56	284	263	257	257
query57	1155	1032	1016	1016
query58	273	254	229	229
query59	3770	3146	3079	3079
query60	286	274	271	271
query61	95	87	88	87
query62	640	442	454	442
query63	319	291	283	283
query64	9794	2194	1812	1812
query65	3195	3099	3115	3099
query66	1347	324	328	324
query67	15373	14930	14963	14930
query68	4576	530	540	530
query69	445	302	300	300
query70	1181	1085	1080	1080
query71	439	285	281	281
query72	7081	5562	5121	5121
query73	731	326	326	326
query74	5932	5557	5501	5501
query75	3439	2643	2659	2643
query76	2819	882	945	882
query77	466	298	291	291
query78	10292	9996	9835	9835
query79	1666	518	506	506
query80	1210	515	450	450
query81	566	220	220	220
query82	1080	100	102	100
query83	247	172	174	172
query84	252	87	87	87
query85	1348	267	266	266
query86	477	308	309	308
query87	3324	3136	3072	3072
query88	3352	2431	2455	2431
query89	471	381	386	381
query90	1786	188	189	188
query91	123	95	96	95
query92	67	50	48	48
query93	2038	521	508	508
query94	1228	192	186	186
query95	396	315	316	315
query96	590	277	274	274
query97	3196	2986	3007	2986
query98	241	221	267	221
query99	1119	807	870	807
Total cold run time: 274145 ms
Total hot run time: 172018 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.09 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 065f7118bbeb31fabd80b97245d14b6ffc9891d5, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.24	0.04	0.05
query4	1.68	0.08	0.08
query5	0.51	0.48	0.48
query6	1.13	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.53	0.49	0.47
query10	0.54	0.55	0.54
query11	0.15	0.12	0.12
query12	0.16	0.12	0.12
query13	0.59	0.59	0.62
query14	0.78	0.78	0.78
query15	0.84	0.81	0.82
query16	0.36	0.35	0.35
query17	1.04	1.02	0.96
query18	0.21	0.25	0.22
query19	1.81	1.71	1.73
query20	0.01	0.01	0.01
query21	15.45	0.74	0.67
query22	3.64	9.11	1.44
query23	18.57	1.31	1.30
query24	1.84	0.24	0.21
query25	0.15	0.08	0.08
query26	0.26	0.17	0.18
query27	0.08	0.08	0.07
query28	13.32	1.02	0.99
query29	13.19	3.35	3.30
query30	0.24	0.05	0.06
query31	2.89	0.39	0.39
query32	3.26	0.48	0.47
query33	2.88	2.93	2.94
query34	17.10	4.39	4.40
query35	4.53	4.48	4.46
query36	0.65	0.46	0.47
query37	0.17	0.16	0.15
query38	0.15	0.14	0.15
query39	0.04	0.04	0.03
query40	0.16	0.15	0.14
query41	0.10	0.05	0.05
query42	0.06	0.06	0.05
query43	0.04	0.03	0.04
Total cold run time: 109.54 s
Total hot run time: 30.09 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

PR approved by anyone and no changes requested.

eldenmoon
eldenmoon approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon mentioned this pull request Jun 5, 2024
Closed
@eldenmoon eldenmoon merged commit a027db1 into apache:master Jun 5, 2024
29 of 31 checks passed
@morrySnow morrySnow added the usercase Important user case type label label Jun 6, 2024
zddr added a commit to zddr/incubator-doris that referenced this pull request Jun 6, 2024
@zddr
[fix](mtmv)Mtmv support row column (apache#35860)
68300d5 
when create mtmv with property `'store_row_column' = 'true'`,and `select
* from mtmv order by xxx limit xxx`
be will core,before MTMV not have hidden column
`__DORIS_ROW_STORE_COL__`
@zddr zddr mentioned this pull request Jun 6, 2024
Merged
morningman pushed a commit that referenced this pull request Jun 6, 2024
@zddr
[fix](mtmv)Mtmv support row column (#35860) (#35956)
9efc7b6 
pick from master: #35860
dataroaring pushed a commit that referenced this pull request Jun 7, 2024
@zddr @dataroaring
[fix](mtmv)Mtmv support row column (#35860)
913ed2c 
when create mtmv with property `'store_row_column' = 'true'`,and `select
* from mtmv order by xxx limit xxx`
be will core,before MTMV not have hidden column
`__DORIS_ROW_STORE_COL__`
@morningman morningman mentioned this pull request Jun 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

@morrySnow morrySnow morrySnow approved these changes

@seawinde seawinde seawinde approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.4-merged dev/3.0.0-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@zddr @doris-robot @eldenmoon @morrySnow @seawinde @morningman @dataroaring