Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) remove getTableInMinidumpCache temporary #35571

Merged
merged 1 commit into from
May 29, 2024
Merged

[fix](Nereids) remove getTableInMinidumpCache temporary #35571

merged 1 commit into from
May 29, 2024

Conversation

morrySnow
Copy link
Contributor

bug introduced by #18747

getTableInMinidumpCache use wrong way to compare table's qualified name. we remove it temporary since it not use in productive env anymore

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow morrySnow added usercase Important user case type label dev/2.0.x dev/2.1.x labels May 29, 2024
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request May 29, 2024
@morrySnow
[fix](Nereids) remove getTableInMinidumpCache temporary
11e139f 
pick from master apache#35571

bug introduced by apache#18747

getTableInMinidumpCache use wrong way to compare table's qualified name.
we remove it temporary since it not use in productive env anymore
@morrySnow morrySnow mentioned this pull request May 29, 2024
Merged
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39832 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 684e7d4371a990e4c21fb186ce2308b59e08d24a, data reload: false

------ Round 1 ----------------------------------
q1	17611	4433	4197	4197
q2	2030	197	193	193
q3	10455	1236	1292	1236
q4	11162	755	797	755
q5	7805	2702	2645	2645
q6	219	129	132	129
q7	954	616	602	602
q8	9629	2057	2110	2057
q9	9180	6565	6593	6565
q10	9170	3834	3668	3668
q11	440	242	243	242
q12	478	220	215	215
q13	17764	2999	2998	2998
q14	271	219	219	219
q15	512	473	467	467
q16	510	382	385	382
q17	942	711	703	703
q18	8035	7299	7343	7299
q19	5990	1517	1504	1504
q20	680	311	311	311
q21	4964	3179	3890	3179
q22	337	266	272	266
Total cold run time: 119138 ms
Total hot run time: 39832 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4381	4225	4180	4180
q2	396	275	268	268
q3	2971	2765	2723	2723
q4	1870	1612	1592	1592
q5	5261	5309	5290	5290
q6	213	121	122	121
q7	2127	1731	1731	1731
q8	3187	3298	3281	3281
q9	8324	8334	8283	8283
q10	3870	3628	3609	3609
q11	581	504	482	482
q12	747	610	588	588
q13	16495	2993	3012	2993
q14	299	261	255	255
q15	511	471	470	470
q16	468	420	420	420
q17	1789	1502	1480	1480
q18	7597	7383	7527	7383
q19	1651	1579	1548	1548
q20	2019	1763	1775	1763
q21	4899	4663	4823	4663
q22	589	494	497	494
Total cold run time: 70245 ms
Total hot run time: 53617 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169515 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 684e7d4371a990e4c21fb186ce2308b59e08d24a, data reload: false

query1	925	379	372	372
query2	6463	2439	2297	2297
query3	6657	203	208	203
query4	19757	17381	17437	17381
query5	4172	419	413	413
query6	253	177	155	155
query7	4587	299	288	288
query8	257	186	180	180
query9	8505	2344	2312	2312
query10	444	269	256	256
query11	10469	10040	10078	10040
query12	132	86	88	86
query13	1641	369	356	356
query14	9416	7570	7536	7536
query15	245	170	167	167
query16	8139	256	260	256
query17	1860	524	499	499
query18	2053	267	275	267
query19	210	172	149	149
query20	91	84	80	80
query21	199	137	126	126
query22	4160	3982	3932	3932
query23	33433	32881	33034	32881
query24	11988	2937	2795	2795
query25	632	343	358	343
query26	1821	152	154	152
query27	2945	332	315	315
query28	7596	2021	2053	2021
query29	1031	594	600	594
query30	271	146	147	146
query31	982	753	738	738
query32	100	52	53	52
query33	765	270	259	259
query34	1028	480	462	462
query35	731	592	584	584
query36	1054	878	899	878
query37	194	66	69	66
query38	2926	2806	2743	2743
query39	843	779	781	779
query40	281	123	127	123
query41	47	46	48	46
query42	104	100	95	95
query43	608	555	567	555
query44	1228	722	738	722
query45	183	167	169	167
query46	1068	719	703	703
query47	1868	1803	1775	1775
query48	378	337	299	299
query49	1184	373	386	373
query50	764	381	372	372
query51	6816	6801	6709	6709
query52	103	90	87	87
query53	346	292	278	278
query54	963	431	423	423
query55	73	71	72	71
query56	263	240	254	240
query57	1144	1035	1029	1029
query58	274	214	208	208
query59	3404	3520	3265	3265
query60	280	260	252	252
query61	91	92	118	92
query62	663	458	457	457
query63	309	281	279	279
query64	9765	2247	1700	1700
query65	3177	3109	3115	3109
query66	1358	341	334	334
query67	15336	14753	14777	14753
query68	4579	536	541	536
query69	452	274	278	274
query70	1214	1108	1031	1031
query71	411	268	274	268
query72	7701	5922	2716	2716
query73	711	322	324	322
query74	6034	5614	5606	5606
query75	3443	2601	2652	2601
query76	2828	1078	919	919
query77	420	316	259	259
query78	10285	9955	9748	9748
query79	2722	514	508	508
query80	1962	441	435	435
query81	535	221	222	221
query82	758	91	89	89
query83	280	172	171	171
query84	263	92	87	87
query85	2111	268	261	261
query86	508	263	295	263
query87	3304	3123	3138	3123
query88	3970	2361	2361	2361
query89	493	406	380	380
query90	1989	188	193	188
query91	125	99	98	98
query92	64	51	51	51
query93	3135	510	506	506
query94	1253	238	184	184
query95	406	317	306	306
query96	599	267	261	261
query97	3157	3009	3026	3009
query98	248	215	209	209
query99	1196	849	856	849
Total cold run time: 278209 ms
Total hot run time: 169515 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.44 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 684e7d4371a990e4c21fb186ce2308b59e08d24a, data reload: false

query1	0.04	0.03	0.03
query2	0.09	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.07	0.06
query5	0.50	0.47	0.50
query6	1.12	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.54	0.51	0.48
query10	0.54	0.54	0.54
query11	0.16	0.11	0.12
query12	0.15	0.13	0.12
query13	0.59	0.59	0.60
query14	0.76	0.78	0.77
query15	0.82	0.82	0.80
query16	0.35	0.36	0.35
query17	0.95	0.95	0.97
query18	0.21	0.25	0.24
query19	1.71	1.74	1.68
query20	0.02	0.01	0.01
query21	15.50	0.69	0.66
query22	3.91	8.00	1.91
query23	18.30	1.39	1.28
query24	1.51	0.33	0.25
query25	0.16	0.09	0.08
query26	0.27	0.17	0.17
query27	0.08	0.07	0.09
query28	13.37	1.02	1.00
query29	12.74	3.32	3.28
query30	0.24	0.07	0.06
query31	2.85	0.39	0.38
query32	3.29	0.47	0.47
query33	2.90	2.88	2.85
query34	17.02	4.36	4.41
query35	4.47	4.51	4.53
query36	0.64	0.47	0.49
query37	0.18	0.15	0.16
query38	0.15	0.15	0.14
query39	0.05	0.04	0.03
query40	0.16	0.13	0.13
query41	0.09	0.05	0.05
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 108.51 s
Total hot run time: 30.44 s

@morrySnow
[fix](Nereids) remove getTableInMinidumpCache temporary
d24cd9e 
bug introduced by apache#18747

getTableInMinidumpCache use wrong way to compare table's qualified name.
we remove it temporary since it not use in productive env anymore
@morrySnow
Copy link
Contributor Author

run buildall

morrySnow added a commit that referenced this pull request May 29, 2024
@morrySnow
[fix](Nereids) remove getTableInMinidumpCache temporary (#35578)
0443fc1 
pick from master #35571

bug introduced by #18747

getTableInMinidumpCache use wrong way to compare table's qualified name.
we remove it temporary since it not use in productive env anymore
@doris-robot
Copy link

TPC-H: Total hot run time: 41218 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d24cd9eecfc59582c3c60cbdcf6f860fa15217a5, data reload: false

------ Round 1 ----------------------------------
q1	17615	4304	4253	4253
q2	2023	201	194	194
q3	10453	1215	1271	1215
q4	10197	787	823	787
q5	7484	2766	2674	2674
q6	221	131	137	131
q7	975	618	617	617
q8	9228	2133	2119	2119
q9	10673	6717	6831	6717
q10	9517	3884	3828	3828
q11	468	244	246	244
q12	444	223	227	223
q13	17222	3188	3191	3188
q14	256	225	234	225
q15	525	478	470	470
q16	508	371	375	371
q17	967	682	716	682
q18	8347	7810	7793	7793
q19	5236	1595	1563	1563
q20	642	323	329	323
q21	5148	3313	4150	3313
q22	356	288	290	288
Total cold run time: 118505 ms
Total hot run time: 41218 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4494	4472	4449	4449
q2	374	268	275	268
q3	3125	2920	2932	2920
q4	2034	1599	1525	1525
q5	5381	5500	5495	5495
q6	218	126	124	124
q7	2225	1780	1819	1780
q8	3261	3419	3393	3393
q9	8586	8694	8704	8694
q10	4105	3743	3767	3743
q11	628	524	502	502
q12	771	628	624	624
q13	15911	3185	3190	3185
q14	297	281	271	271
q15	542	482	480	480
q16	485	426	444	426
q17	1838	1515	1533	1515
q18	7801	7675	7522	7522
q19	1658	1575	1565	1565
q20	1988	1800	1780	1780
q21	9521	4648	4741	4648
q22	607	477	512	477
Total cold run time: 75850 ms
Total hot run time: 55386 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172636 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d24cd9eecfc59582c3c60cbdcf6f860fa15217a5, data reload: false

query1	914	386	368	368
query2	6446	2509	2241	2241
query3	6643	201	203	201
query4	19303	17349	17316	17316
query5	4131	421	430	421
query6	254	154	152	152
query7	4590	302	288	288
query8	240	185	183	183
query9	8461	2492	2475	2475
query10	447	293	260	260
query11	10519	10026	9923	9923
query12	137	86	90	86
query13	1652	356	358	356
query14	10074	7574	7420	7420
query15	214	165	172	165
query16	7793	268	274	268
query17	1683	524	526	524
query18	1960	267	267	267
query19	212	156	153	153
query20	91	85	89	85
query21	196	130	129	129
query22	4261	4064	3985	3985
query23	33649	33042	33029	33029
query24	6800	2825	2820	2820
query25	570	350	356	350
query26	704	152	154	152
query27	2042	317	330	317
query28	3608	2096	2100	2096
query29	853	647	603	603
query30	235	147	151	147
query31	960	763	735	735
query32	91	53	53	53
query33	494	275	261	261
query34	868	484	489	484
query35	712	618	604	604
query36	1035	914	895	895
query37	103	67	65	65
query38	2902	2772	2748	2748
query39	850	792	785	785
query40	196	126	122	122
query41	52	44	43	43
query42	103	93	101	93
query43	607	553	553	553
query44	1066	730	751	730
query45	180	163	165	163
query46	1049	743	705	705
query47	1865	1813	1807	1807
query48	404	299	295	295
query49	828	383	386	383
query50	768	384	390	384
query51	6842	6740	6617	6617
query52	106	89	92	89
query53	350	288	282	282
query54	557	444	455	444
query55	77	73	73	73
query56	264	239	238	238
query57	1129	1072	1021	1021
query58	226	222	232	222
query59	3547	3181	3264	3181
query60	277	283	255	255
query61	93	86	84	84
query62	606	452	453	452
query63	311	282	278	278
query64	8421	2220	1764	1764
query65	3162	3072	3132	3072
query66	788	329	317	317
query67	15197	14855	14773	14773
query68	4501	554	564	554
query69	437	272	267	267
query70	1193	1112	1089	1089
query71	372	271	266	266
query72	7335	5456	5556	5456
query73	728	329	332	329
query74	6060	5679	5661	5661
query75	3339	2641	2612	2612
query76	2338	996	999	996
query77	386	266	268	266
query78	10312	9724	9616	9616
query79	2127	515	514	514
query80	1041	435	446	435
query81	518	224	220	220
query82	656	93	99	93
query83	308	165	164	164
query84	243	86	85	85
query85	1633	265	262	262
query86	531	314	326	314
query87	3272	3114	3089	3089
query88	4276	2457	2442	2442
query89	470	393	381	381
query90	2020	185	185	185
query91	122	101	106	101
query92	56	47	53	47
query93	2933	530	519	519
query94	1156	187	189	187
query95	403	315	312	312
query96	592	273	271	271
query97	3201	3007	3047	3007
query98	238	227	208	208
query99	1137	869	838	838
Total cold run time: 259702 ms
Total hot run time: 172636 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.07 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d24cd9eecfc59582c3c60cbdcf6f860fa15217a5, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.03	0.04
query3	0.23	0.04	0.05
query4	1.69	0.07	0.07
query5	0.51	0.49	0.49
query6	1.15	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.49	0.49
query10	0.54	0.56	0.53
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.60	0.59	0.59
query14	0.78	0.78	0.77
query15	0.82	0.79	0.80
query16	0.37	0.35	0.37
query17	1.02	0.93	0.99
query18	0.23	0.24	0.23
query19	1.79	1.71	1.68
query20	0.01	0.01	0.02
query21	15.73	0.66	0.65
query22	4.39	7.74	1.57
query23	18.26	1.43	1.31
query24	1.60	0.35	0.21
query25	0.14	0.08	0.08
query26	0.26	0.16	0.16
query27	0.07	0.08	0.07
query28	13.34	1.01	0.99
query29	12.78	3.30	3.27
query30	0.24	0.06	0.05
query31	2.87	0.39	0.38
query32	3.29	0.47	0.46
query33	2.87	2.90	2.89
query34	17.21	4.45	4.39
query35	4.51	4.45	4.55
query36	0.66	0.51	0.49
query37	0.17	0.16	0.17
query38	0.16	0.14	0.15
query39	0.04	0.04	0.03
query40	0.16	0.14	0.15
query41	0.09	0.05	0.05
query42	0.05	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.7 s
Total hot run time: 30.07 s

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow
Copy link
Contributor Author

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit f6e624a into apache:master May 29, 2024
25 of 26 checks passed
@morrySnow morrySnow deleted the fix_minidump_get_table branch May 29, 2024 12:22
yiguolei pushed a commit that referenced this pull request May 29, 2024
@morrySnow @Doris-Extras
[fix](Nereids) remove getTableInMinidumpCache temporary (#35571)
f6e8c53 
bug introduced by #18747

getTableInMinidumpCache use wrong way to compare table's qualified name.
we remove it temporary since it not use in productive env anymore
dataroaring pushed a commit that referenced this pull request May 31, 2024
@morrySnow @dataroaring
[fix](Nereids) remove getTableInMinidumpCache temporary (#35571)
6aff5b1 
bug introduced by #18747

getTableInMinidumpCache use wrong way to compare table's qualified name.
we remove it temporary since it not use in productive env anymore
@morningman morningman mentioned this pull request Jun 22, 2024
Closed
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@morrySnow
[fix](Nereids) remove getTableInMinidumpCache temporary (apache#35578)
219a149 
pick from master apache#35571

bug introduced by apache#18747

getTableInMinidumpCache use wrong way to compare table's qualified name.
we remove it temporary since it not use in productive env anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 approved these changes

@LiBinfeng-01 LiBinfeng-01 LiBinfeng-01 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.11-merged dev/2.1.4-merged dev/3.0.0-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@morrySnow @doris-robot @starocean999 @LiBinfeng-01 @dataroaring