-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](Nereids) DatetimeV2 round floor was incorrectly implemented as round ceil #35153
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
…round ceil pick from master apache#35153
…round ceil pick from master apache#35153
run buildall |
6794192
to
6292919
Compare
…round ceil pick from master apache#35153
…round ceil pick from master apache#35153
run buildall |
TPC-H: Total hot run time: 40114 ms
|
TPC-DS: Total hot run time: 180670 ms
|
ClickBench: Total hot run time: 30.14 s
|
...re/src/test/java/org/apache/doris/nereids/trees/expressions/literal/DateTimeLiteralTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by anyone and no changes requested. |
6292919
to
70487db
Compare
…round ceil pick from master apache#35153
…round ceil pick from master apache#35153
70487db
to
bb8385f
Compare
run buildall |
TPC-H: Total hot run time: 42062 ms
|
…round ceil pick from master apache#35153
TPC-DS: Total hot run time: 181957 ms
|
ClickBench: Total hot run time: 31.01 s
|
bb8385f
to
ec87be0
Compare
run buildall |
…round ceil pick from master apache#35153
TPC-DS: Total hot run time: 180923 ms
|
ClickBench: Total hot run time: 30.63 s
|
run p0 |
PR approved by at least one committer and no changes requested. |
…che#35153) (apache#35154) pick from master apache#35153 1. round floor was incorrectly implemented as round 2. round ceiling not really round because use double type when divide
No description provided.