-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](JDK17) Start Fe with JDK17 #30485
Conversation
run buildall |
TPC-H: Total hot run time: 37894 ms
|
TPC-DS: Total hot run time: 173702 ms
|
ClickBench: Total hot run time: 31.12 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue Number: close #30484 problem: gson will use Java's reflection mechanism to generate a default Adapter, but JDK17 is prohibited from visiting such an access. solution: gson has provided solutions since 2.9.1, which can bypass this problem: Add support for reflection access filter by Marcono1234 · Pull Request #1905 · google/gson We need to upgrade the gson version and use this solution
Proposed changes
Issue Number: #30484
problem:
gson
will use Java's reflection mechanism to generate a default Adapter, but JDK17 is prohibited from visiting such an access.solution:
gson
has provided solutions since 2.9.1, which can bypass this problem: Add support for reflection access filter by Marcono1234 · Pull Request #1905 · google/gsonWe need to upgrade the gson version and use this solution
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...