[Feature][Registry][WIP] Connecting to the ZooKeeper with SSL&ACL #16271
Conversation
pegasas
requested review from
caishunfeng,
SbloodyS,
ruanwenjun and
Gallardot
as code owners
|
|
|
||
| final String x509SubjectPrincipal = properties.getX509SubjectPrincipal(); | ||
| if (!Strings.isNullOrEmpty(x509SubjectPrincipal)) { | ||
| builder.authorization("x509", digest.getBytes(StandardCharsets.UTF_8)) |
There was a problem hiding this comment.
We should extract x509 to Constans.
There was a problem hiding this comment.
how about change both digest/x509 into AuthSchema? see https://github.com/apache/zookeeper/blob/39973dc5fddf778733e4f0370980629c07a16d67/zookeeper-server/src/test/java/org/apache/zookeeper/server/admin/CommandAuthTest.java#L79
There was a problem hiding this comment.
how about change both digest/x509 into AuthSchema? see https://github.com/apache/zookeeper/blob/39973dc5fddf778733e4f0370980629c07a16d67/zookeeper-server/src/test/java/org/apache/zookeeper/server/admin/CommandAuthTest.java#L79
I'm ok with it.
There was a problem hiding this comment.
It's better to add an authorization property and use the key/value provided by users
authorization:
key: value
pegasas
changed the title
Purpose of the pull request
fix: Feature
Brief change log
add x509 authinfo for zk registry
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md