[DSIP-54][Master] Use ClusterManager to manage the cluster in master #16263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
EricGao888,
SbloodyS,
caishunfeng and
Gallardot
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_refactorServerNodeManager
branch
2 times, most recently
from
d42e876
to
7bef33a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...eduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/IClusters.java
Fixed
Show fixed
Hide fixed
...eduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/IClusters.java
Fixed
Show fixed
Hide fixed
...eduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/IClusters.java
Fixed
Show fixed
Hide fixed
...eduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/IClusters.java
Fixed
Show fixed
Hide fixed
...eduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/IClusters.java
Fixed
Show fixed
Hide fixed
...ler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/MasterServer.java
Fixed
Show fixed
Hide fixed
...ler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/WorkerServer.java
Fixed
Show fixed
Hide fixed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #16263 +/- ##
============================================
- Coverage 41.17% 41.07% -0.11%
+ Complexity 5093 5083 -10
============================================
Files 1391 1396 +5
Lines 43803 43674 -129
Branches 4645 4621 -24
============================================
- Hits 18038 17938 -100
+ Misses 23997 23976 -21
+ Partials 1768 1760 -8 ☔ View full report in Codecov by Sentry. |
SbloodyS
changed the title
ruanwenjun
force-pushed
the
dev_wenjun_refactorServerNodeManager
branch
from
7bef33a
to
61210f3
Compare
...eduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/IClusters.java
Fixed
Show fixed
Hide fixed
|
|
||
| @Data | ||
| @SuperBuilder | ||
| @EqualsAndHashCode(callSuper = true) |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
|
|
||
| @Data | ||
| @SuperBuilder | ||
| @EqualsAndHashCode(callSuper = true) |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
ruanwenjun
force-pushed
the
dev_wenjun_refactorServerNodeManager
branch
5 times, most recently
from
9fa1ea9
to
55750ba
Compare
ruanwenjun
force-pushed
the
dev_wenjun_refactorServerNodeManager
branch
from
55750ba
to
a8ed188
Compare
ruanwenjun
force-pushed
the
dev_wenjun_refactorServerNodeManager
branch
from
a8ed188
to
f26012b
Compare
|
Please retry analysis of this Pull-Request directly on SonarCloud |
Gallardot
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16262
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md