[Feature] [Task Plugin] Support emr serverless spark #16126
Conversation
EricGao888
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| aliyunServerlessSparkClient = new Client(config); | ||
| } | ||
|
|
||
| public boolean checkConnect(String accessKeyId, String accessKeySecret, String regionId) { |
Check notice
Code scanning / CodeQL
Useless parameter
There was a problem hiding this comment.
Currently Aliyun EMR Serverless Spark service does not have a specific API to test connection.
| aliyunServerlessSparkClient = new Client(config); | ||
| } | ||
|
|
||
| public boolean checkConnect(String accessKeyId, String accessKeySecret, String regionId) { |
Check notice
Code scanning / CodeQL
Useless parameter
| aliyunServerlessSparkClient = new Client(config); | ||
| } | ||
|
|
||
| public boolean checkConnect(String accessKeyId, String accessKeySecret, String regionId) { |
Check notice
Code scanning / CodeQL
Useless parameter
...org/apache/dolphinscheduler/plugin/task/aliyunserverlessspark/AliyunServerlessSparkTask.java
Fixed
Show fixed
Hide fixed
...org/apache/dolphinscheduler/plugin/task/aliyunserverlessspark/AliyunServerlessSparkTask.java
Fixed
Show fixed
Hide fixed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #16126 +/- ##
============================================
+ Coverage 40.71% 40.81% +0.10%
- Complexity 5246 5273 +27
============================================
Files 1385 1397 +12
Lines 46109 46324 +215
Branches 4923 4931 +8
============================================
+ Hits 18771 18908 +137
- Misses 25412 25482 +70
- Partials 1926 1934 +8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: EricGao888 <[email protected]>
EricGao888
force-pushed
the
support-emr-serverless-spark-community
branch
from
33cc954
to
c107f11
Compare
EricGao888
requested review from
songjianet,
Amy0104,
caishunfeng,
SbloodyS and
zhuangchong
as code owners
| } catch (Exception e) { | ||
| log.info("spark client failed to connect to the server"); |
There was a problem hiding this comment.
Is it better to print stack trace to the logs for better debug?
There was a problem hiding this comment.
Thanks, I missed this one, will fix it.
|
|
||
| protected Client buildAliyunServerlessSparkClient(String accessKeyId, String accessKeySecret, | ||
| String regionId) throws Exception { | ||
| String endpoint = String.format("emr-serverless-spark.%s.aliyuncs.com", regionId); |
There was a problem hiding this comment.
I have seen this string in some other places, maybe a constant is more suitable.
| throws Exception { | ||
|
|
||
| checkNotNull(accessKeyId, accessKeySecret, regionId); | ||
| String endpoint = String.format("emr-serverless-spark.%s.aliyuncs.com", regionId); |
There was a problem hiding this comment.
Overall LGTM, maybe we should make endpoint as a config since users may use endpoint in other formats (etc., in VPC).
There was a problem hiding this comment.
Good point. Will make it configurable.
|
Please retry analysis of this Pull-Request directly on SonarCloud |
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md