[Improvement-16106] Add the "memberOf" attributes to identify ADMIN users. #16105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
raised improvement request #16106 |
SbloodyS
changed the title
SbloodyS
changed the title
SbloodyS
requested changes
Jun 3, 2024
...eduler-api/src/main/java/org/apache/dolphinscheduler/api/security/impl/ldap/LdapService.java
Outdated
Show resolved
Hide resolved
…" can be used together or uniquely.
|
Improved feature by replacing "admin-attribute" and "admin-value" with "admin-filter" so a filter check is applied to find admin users. This will enabled different LDAP setup for ROLES. The filter makes it very generic to identify the ADMIN role For the "ldap.forumsys.com" were we make all scientist admins security.authentication.ldap.user.admin-filter=(&(ou=scientists)(uniqueMember=uid={0},dc=example,dc=com)) to the use of "memberOf" assigning of roles. security.authentication.ldap.user.admin-filter=(&(sAMAccountName={0})(memberOf=CN=admin,OU=dolphin,DC=example,DC=com) |
SbloodyS
reviewed
Jun 10, 2024
...eduler-api/src/main/java/org/apache/dolphinscheduler/api/security/impl/ldap/LdapService.java
Outdated
Show resolved
Hide resolved
...eduler-api/src/main/java/org/apache/dolphinscheduler/api/security/impl/ldap/LdapService.java
Outdated
Show resolved
Hide resolved
Co-authored-by: xiangzihao <[email protected]>
remove redundant security.authentication.ldap.filter property. Not required.
Co-authored-by: xiangzihao <[email protected]>
Co-authored-by: xiangzihao <[email protected]>
SbloodyS
reviewed
Jun 28, 2024
| | api.traffic.control.tenant-switch | false | traffic control tenant switch | | ||
| | api.traffic.control.default-tenant-qps-rate | 10 | default tenant max request number per second | | ||
| | api.traffic.control.customize-tenant-qps-rate | | customize tenant max request number per second | | ||
| | Parameters | Default value | Description | |
There was a problem hiding this comment.
Please avoid unnessnary change.
run spotless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16106
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md