revert: Datasource need test binding to create prod #14381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should keep our step as less as possible, for now we have to test datasource and binding it to prod datasource, I think is will make our users do not thing to use datasource, so I do like to revert it and keep step as less as possible related to apache#11670
zhongjiajie
requested review from
songjianet,
caishunfeng,
SbloodyS and
kezhenxu94
as code owners
zhongjiajie
added
3.2.0
34 tasks
|
Kudos, SonarCloud Quality Gate passed! |
SbloodyS
approved these changes
Jun 25, 2023
IT-Kwj
pushed a commit
to IT-Kwj/dolphinscheduler
that referenced
this pull request
Jul 14, 2023
We should keep our step as less as possible, for now, we have to test datasource and binding it to the prod datasource, I think it will make our users do not thing to use datasource, so I do like to revert it and keep step as less as possible related to apache#11670
biaoma-ty
pushed a commit
to Kasma-Inc/dolphinscheduler
that referenced
this pull request
Aug 17, 2023
We should keep our step as less as possible, for now, we have to test datasource and binding it to the prod datasource, I think it will make our users do not thing to use datasource, so I do like to revert it and keep step as less as possible related to apache#11670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should keep our step as less as possible, for now we have to test datasource and binding it to prod datasource, I think is will make our users do not thing to use datasource, so I do like to revert it and keep step as less as possible
related to #11670