Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Improve support test tasks UT #12062

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Conversation

insist777
Copy link
Contributor

Purpose of the pull request

close #12061

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

Codecov Report

Merging #12062 (edc68ee) into dev (e1b55db) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #12062      +/-   ##
============================================
- Coverage     38.65%   38.64%   -0.01%     
+ Complexity     4004     4001       -3     
============================================
  Files          1002     1002              
  Lines         37215    37184      -31     
  Branches       4251     4243       -8     
============================================
- Hits          14386    14371      -15     
+ Misses        21195    21179      -16     
  Partials       1634     1634              
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 42.55% <0.00%> (-2.13%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.42% <0.00%> (-1.43%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 55.12% <0.00%> (-1.29%) ⬇️
...rver/master/runner/task/BlockingTaskProcessor.java 75.86% <0.00%> (-0.55%) ⬇️
...heduler/api/service/impl/ResourcesServiceImpl.java 51.68% <0.00%> (-0.47%) ⬇️
...eduler/api/service/impl/DataSourceServiceImpl.java 29.14% <0.00%> (ø)
...cheduler/server/master/utils/DependentExecute.java 0.00% <0.00%> (ø)
.../dolphinscheduler/plugin/task/datax/DataxTask.java 0.00% <0.00%> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

46.2% 46.2% Coverage
0.0% 0.0% Duplication

Copy link
Member

@EricGao888 EricGao888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested locally. It works.

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Sep 20, 2022
@SbloodyS SbloodyS added this to the 3.1.0 milestone Sep 20, 2022
@EricGao888 EricGao888 added bug Something isn't working and removed improvement make more easy to user or prompt friendly labels Sep 20, 2022
@EricGao888
Copy link
Member

Actually, CI may not run some cases in this test class because there are both jUnit4 and jUnit5 style cases. And this kind of problem also exists in other 33 files. It looks like although we haven't add explicit dependency of jUnit5 yet, both versions of test cases have existed in DS project for a long time. Maybe we have some transitive dependencies on jUnit5 in this project.

But this is out of the scope of this PR. I will handle them when doing DSIP-10 #10573

cc @SbloodyS @caishunfeng @ruanwenjun

image

@EricGao888 EricGao888 merged commit 955e8eb into apache:dev Sep 20, 2022
@caishunfeng caishunfeng modified the milestones: 3.1.0, 3.2.0 Sep 20, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
@insist777 insist777 deleted the improveUt branch November 23, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][UT] Improvement Query dataSource UT
5 participants