-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve] Improve support test tasks UT #12062
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #12062 +/- ##
============================================
- Coverage 38.65% 38.64% -0.01%
+ Complexity 4004 4001 -3
============================================
Files 1002 1002
Lines 37215 37184 -31
Branches 4251 4243 -8
============================================
- Hits 14386 14371 -15
+ Misses 21195 21179 -16
Partials 1634 1634
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested locally. It works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Actually, CI may not run some cases in this test class because there are both jUnit4 and jUnit5 style cases. And this kind of problem also exists in other 33 files. It looks like although we haven't add explicit dependency of jUnit5 yet, both versions of test cases have existed in DS project for a long time. Maybe we have some transitive dependencies on jUnit5 in this project. But this is out of the scope of this PR. I will handle them when doing DSIP-10 #10573 |
Purpose of the pull request
close #12061
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md