Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][Test] Give an example on replacing Powermock with Mockito #11588

Merged
merged 9 commits into from
Sep 20, 2022

Conversation

EricGao888
Copy link
Member

@EricGao888 EricGao888 commented Aug 22, 2022

Purpose of the pull request

  • Give an example on replacing Powermock with Mockito.

  • Considering the workload, I'm not going to refactoring all the UTs which use Powermock in one PR. This is an example as the beginning work of this issue. If the example looks good, I will have two more contributors finish the remaining work together with me.

  • related: [Improvement][Test] Remove dependency of powermock #11405

Brief change log

  • Already described above.

Verify this pull request

  • Verified by UT.

@EricGao888 EricGao888 self-assigned this Aug 22, 2022
@EricGao888 EricGao888 marked this pull request as ready for review August 22, 2022 06:07
@SbloodyS SbloodyS added this to the 3.1.0 milestone Aug 22, 2022
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Aug 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #11588 (34120cd) into dev (ad683c3) will decrease coverage by 0.01%.
The diff coverage is 20.00%.

@@             Coverage Diff              @@
##                dev   #11588      +/-   ##
============================================
- Coverage     38.68%   38.66%   -0.02%     
+ Complexity     4006     4005       -1     
============================================
  Files          1002     1002              
  Lines         37213    37215       +2     
  Branches       4249     4251       +2     
============================================
- Hits          14394    14390       -4     
- Misses        21186    21190       +4     
- Partials       1633     1635       +2     
Impacted Files Coverage Δ
...heduler/plugin/task/jupyter/JupyterParameters.java 0.00% <0.00%> (-33.34%) ⬇️
...inscheduler/plugin/task/zeppelin/ZeppelinTask.java 50.54% <ø> (ø)
...phinscheduler/plugin/task/jupyter/JupyterTask.java 62.85% <50.00%> (-0.61%) ⬇️
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

SbloodyS
SbloodyS previously approved these changes Sep 19, 2022
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@EricGao888 EricGao888 merged commit e1b55db into apache:dev Sep 20, 2022
@caishunfeng caishunfeng modified the milestones: 3.1.0, 3.2.0 Sep 20, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
…to (apache#11588)

* Give an example on replacing powermock with mockito

* Remove redundant comments

* Refactoring related UTs for better readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants