Fix datafusion-cli publishing #9955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Apr 4, 2024
| @@ -26,9 +26,9 @@ use datafusion::arrow::array::{ArrayRef, StringArray}; | |||
| use datafusion::arrow::datatypes::{DataType, Field, Schema}; | |||
| use datafusion::arrow::record_batch::RecordBatch; | |||
| use datafusion::common::exec_err; | |||
| use datafusion::common::instant::Instant; | |||
There was a problem hiding this comment.
the whole change is datafusion_common --> datafusion::common
alamb
commented
Apr 4, 2024
| @@ -45,7 +45,6 @@ datafusion = { path = "../datafusion/core", version = "37.0.0", features = [ | |||
| "unicode_expressions", | |||
| "compression", | |||
| ] } | |||
| datafusion-common = { path = "../datafusion/common" } | |||
There was a problem hiding this comment.
I had to change this to
datafusion-common = { path = "../datafusion/common", version="37.0.0" }to get datafusion-cli to publish. I think removing the whole dependency is cleaner that adding a version that needs to be kept in sync
|
Thank you @Jefffrey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #9682
Rationale for this change
I had to add a
versionfield to the datafusion-cliCargo.tomlfile to correctly publish to crates.io asdatafusion-commondid not specify a versionWhat changes are included in this PR?
datafusiondependencyAre these changes tested?
By C
Are there any user-facing changes?
No