Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cbrt, cos, cosh, degrees to datafusion-functions #9938

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Move cbrt, cos, cosh, degrees to datafusion-functions #9938

merged 1 commit into from
Apr 4, 2024

Conversation

erenavsarogullari
Copy link
Member

Which issue does this PR close?

Closes #9862.

What changes are included in this PR?

cbrt, cos, cosh, degrees functions are moved to datafusion-functions crate.

Are these changes tested?

Yes, all scalar.slt based cbrt, cos, cosh, degrees functions' tests are passed.

Are there any user-facing changes?

No

@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Physical Expressions labels Apr 4, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thank you for keeping the train moving @erenavsarogullari 🙏

@alamb alamb merged commit ad3e008 into apache:main Apr 4, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move Cbrt, Cos, Cosh, Degrees to datafusion-functions
2 participants