Move AggregateExpr, PhysicalExpr and PhysicalSortExpr to physical-expr-core
#9926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
jayzhan211
commented
Apr 4, 2024
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
jayzhan211
commented
Apr 4, 2024
| /// [`create_physical_expr`]: https://docs.rs/datafusion/latest/datafusion/physical_expr/fn.create_physical_expr.html | ||
| /// | ||
| /// # Example: Create `PhysicalExpr` from `Expr` | ||
| /// ```ignore |
There was a problem hiding this comment.
Since datafusion_physical_expr::create_physical_expr should stay in physical-expr, so we can't run the doc test here.
There was a problem hiding this comment.
I suggest we move the examples to create_physical_expr so it continues to run in tests and link to it via html. Something like
See [create_physical_expr] for examples of creating `PhysicalExpr` from `Expr`:
[create_physical_expr]: https://docs.rs/datafusion/latest/datafusion/physical_expr/fn.create_physical_expr.html
alamb
changed the title
AggregateExpr, PhysicalExpr and PhysicalSortExpr to physical-expr-core
alamb
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Thanks @jayzhan211 -- this looks quite good to me. It is a very exciting step forward
I suggest renaming this crate to datafusion-physical-expr-common to follow the same pattern of datafusion-common but I don't think that is required
cc @mustafasrepo and @berkaysynnada
Comment on lines
24
to
25
| This crate is a submodule of DataFusion that provides the core functionality of physical expressions. | ||
| Like `PhysicalExpr` or `PhysicalSortExpr` and related things. |
There was a problem hiding this comment.
Here is a very minor suggestion:
Suggested change
| This crate is a submodule of DataFusion that provides the core functionality of physical expressions. | |
| Like `PhysicalExpr` or `PhysicalSortExpr` and related things. | |
| This crate is a submodule of DataFusion that provides shared APIs for implementing | |
| physical expressions such as `PhysicalExpr` and `PhysicalSortExpr`. |
| /// [`create_physical_expr`]: https://docs.rs/datafusion/latest/datafusion/physical_expr/fn.create_physical_expr.html | ||
| /// | ||
| /// # Example: Create `PhysicalExpr` from `Expr` | ||
| /// ```ignore |
There was a problem hiding this comment.
I suggest we move the examples to create_physical_expr so it continues to run in tests and link to it via html. Something like
See [create_physical_expr] for examples of creating `PhysicalExpr` from `Expr`:
[create_physical_expr]: https://docs.rs/datafusion/latest/datafusion/physical_expr/fn.create_physical_expr.html
| use arrow::datatypes::Field; | ||
| use datafusion_common::{not_impl_err, Result}; | ||
| use datafusion_expr::{Accumulator, GroupsAccumulator}; | ||
| pub use datafusion_physical_expr_core::aggregate::AggregateExpr; |
There was a problem hiding this comment.
💯 for backwards compatibility
| @@ -80,7 +80,8 @@ pub use crate::PhysicalSortExpr; | |||
| pub use binary::{binary, BinaryExpr}; | |||
| pub use case::{case, CaseExpr}; | |||
| pub use cast::{cast, cast_with_options, CastExpr}; | |||
| pub use column::{col, Column, UnKnownColumn}; | |||
| pub use column::UnKnownColumn; | |||
| pub use datafusion_physical_expr_core::expressions::column::{col, Column}; | |||
7 tasks
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
mustafasrepo
approved these changes
Apr 5, 2024
|
Thanks @jayzhan211 and @mustafasrepo 🚀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9921.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?