feat: pass SessionState not SessionConfig to FunctionFactory::create #9837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
This makes sense to me.
cc @milenkovicm do you remember if there is any reason we should only use the SessionConfig rather than SessionState?
|
not sure whats the status with datafusion v.37 release (#9682) , will this PR make it? |
Yes, this shoudl make 37.0.0 I think. I'll plan to make a release tomorrow |
|
Thanks @alamb, thanks @milenkovicm |
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9838.
Rationale for this change
Right now
FunctionFactory::createtakes a&SessionConfigand not a&SessionState. This limits some of its utility (e.g. access to the object store) and makes it currently out of line with at leastTableProviderFactory, which takes a&SessionStateas well. The name of the parameter is alsostatewhich makes me think that was the original intention.What changes are included in this PR?
Update the trait signature for
FunctionFactory::createso that gets passed&SessionState.Are these changes tested?
Existing tests around
FunctionFactoryare mostly unchanged.Are there any user-facing changes?
Users of
FunctionFactorywill have to update their code.Edit: I can't add the api-change label or I would.