Move bit_length and chr functions to datafusion_functions #9782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
alamb
reviewed
Mar 24, 2024
| @@ -111,7 +111,7 @@ async fn test_fn_ascii() -> Result<()> { | |||
|
|
|||
| #[tokio::test] | |||
| async fn test_fn_bit_length() -> Result<()> { | |||
| let expr = bit_length(col("a")); | |||
| let expr = bit_length(vec![col("a")]); | |||
There was a problem hiding this comment.
since bit_length only ever takes a single parameter, I think it would be better to keep this as a single expr argument (to keep the UX nicer to call bit_length).
If the function can take potentially different numbers of parameters, that is when Vec<Expr> is more appropriate I think
Signed-off-by: Chojan Shang <[email protected]>
Signed-off-by: Chojan Shang <[email protected]>
Signed-off-by: Chojan Shang <[email protected]>
Signed-off-by: Chojan Shang <[email protected]>
Signed-off-by: Chojan Shang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9534.
Rationale for this change
As part of #9285 the bit_length and chr string functions should be migrated to the new datafusion-functions crate in the new structure
What changes are included in this PR?
Move bit_length and chr functions to datafusion_functions
Are these changes tested?
yes
Are there any user-facing changes?
No