Move levenshtein, uuid, overlay to datafusion-functions #9760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailable feature in DataFusion and building with nightly may not be a good recommendation when getting started.
github-actions
bot
added
sql
7 tasks
alamb
approved these changes
Mar 24, 2024
| @@ -75,6 +75,8 @@ log = { workspace = true } | |||
| md-5 = { version = "^0.10.0", optional = true } | |||
| regex = { version = "1.8", optional = true } | |||
| sha2 = { version = "^0.10.1", optional = true } | |||
| uuid = { version = "1.7", features = ["v4"] } | |||
There was a problem hiding this comment.
I think technically this could be an optional depdendece (on string expressions) but since datafusion-core relies on uuid too. I'll try and clean it up as a follow on
| @@ -660,11 +660,11 @@ enum ScalarFunction { | |||
| // 118 was ToTimestampNanos | |||
| // 119 was ArrayIntersect | |||
| // 120 was ArrayUnion | |||
| OverLay = 121; | |||
| // 121 was OverLay | |||
There was a problem hiding this comment.
wow we are pretty close to finishing this list 🤯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9758
Rationale for this change
Function migration.
What changes are included in this PR?
Code, tests.
Are these changes tested?
Yes
Are there any user-facing changes?
No