Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update COPY documentation to reflect changes #9754

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 23, 2024

Which issue does this PR close?

Part of #9369

Rationale for this change

#9604 from @metesynnada rationalized the COPY syntax to match CREATE EXTERNAL TABLE syntax.

Now we need to update the documentation to match

What changes are included in this PR?

Update copy documentation to match new behavior

Are these changes tested?

Are there any user-facing changes?

@alamb alamb added the documentation Improvements or additions to documentation label Mar 23, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Mar 23, 2024
@alamb alamb requested a review from metesynnada March 23, 2024 11:47
@alamb
Copy link
Contributor Author

alamb commented Mar 29, 2024

@metesynnada would you have some time to review this PR?

Copy link
Contributor

@metesynnada metesynnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this reflects the current situation well. I shouldn't have missed changing this file before, I just noticed it. Thanks for the effort.

@alamb
Copy link
Contributor Author

alamb commented Mar 29, 2024

I believe this reflects the current situation well. I shouldn't have missed changing this file before, I just noticed it. Thanks for the effort.

No problem -- things are super busy these days. I appreciate the review 🙏

@alamb alamb added the documentation Improvements or additions to documentation label Mar 29, 2024
@alamb alamb merged commit 2956ec2 into apache:main Mar 29, 2024
4 checks passed
Lordworms pushed a commit to Lordworms/arrow-datafusion that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants