Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port ArrayDistinct to functions-array subcrate #9549

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Port ArrayDistinct to functions-array subcrate #9549

merged 3 commits into from
Mar 12, 2024

Conversation

erenavsarogullari
Copy link
Member

@erenavsarogullari erenavsarogullari commented Mar 11, 2024 •
edited
Loading

Which issue does this PR close?

Closes #9545.

What changes are included in this PR?

This PR aims to do following changes in terms of Epic #9285:
1- ArrayDistinct is ported to functions-array subcrate,
2- general_array_distinct is ported to kernels.rs but could not be removed from array_expressions.rs due to its legacy references: ref
3- ScalarUDFImpl. return_type has been implemented to support input types: List, FixedSizeList and LargeList,
4- Function Documentation is added.

Are these changes tested?

Yes, all array.slt based array_distinct tests are passed.

Are there any user-facing changes?

No

@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Physical Expressions labels Mar 11, 2024
@erenavsarogullari erenavsarogullari mentioned this pull request Mar 11, 2024
Closed
43 tasks
@Weijun-H
Copy link
Member

Hi @erenavsarogullari , could you add a roundtrip test here?
https://github.com/apache/arrow-datafusion/blob/4cd3c433004a7a6825643d6b3911db720efe5f76/datafusion/proto/tests/cases/roundtrip_logical_plan.rs#L582-L611

@erenavsarogullari
Copy link
Member Author

@Weijun-H Thanks for the review. It is added.

@erenavsarogullari erenavsarogullari changed the title Port ArrayDistinct to function-arrays subcrate Port ArrayDistinct to functions-array subcrate Mar 12, 2024
Weijun-H
Weijun-H approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@Weijun-H Weijun-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @erenavsarogullari 👍

jayzhan211
jayzhan211 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erenavsarogullari

@jayzhan211 jayzhan211 merged commit 30c4fd7 into apache:main Mar 12, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayzhan211 jayzhan211 jayzhan211 approved these changes

@Weijun-H Weijun-H Weijun-H approved these changes

Assignees
No one assigned
Labels
logical-expr Logical plan and expressions physical-expr Physical Expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port ArrayDistinct to functions-array subcrate
3 participants
@erenavsarogullari @Weijun-H @jayzhan211