feat: add more components to the wasm-pack compatible list #8843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
waynexia
commented
Jan 12, 2024
Comment on lines
+40
to
41
| [dev-dependencies] | ||
| tokio = "1.17" |
There was a problem hiding this comment.
I move this to dev-dependencies casually. But datafusion-substrait and datafusion-proto are not supported yet.
Signed-off-by: Ruihang Xia <[email protected]>
7 tasks
alamb
approved these changes
Jan 12, 2024
|
|
||
| datafusion-common = { workspace = true } | ||
| datafusion-execution = { workspace = true } |
There was a problem hiding this comment.
I double checked and this addition means that the wasm ci job now checks these crates
https://github.com/apache/arrow-datafusion/blob/8353a2ca2fd1f0ed5fc764b7463dfbcaa033ceef/.github/workflows/rust.yml#L192-L207
Here is the example CI run from this PR showing the new crates building in wasm https://github.com/apache/arrow-datafusion/actions/runs/7504130188/job/20430447784?pr=8843#step:6:194
|
Thanks for your review @alamb |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #7633
Rationale for this change
Make more components to be
wasm-unknown-unknowncompatible.About the background and motivation: I'm trying to continue my side project that builds a web playground based on wasm for datafuson https://github.com/waynexia/datafusion-playground
What changes are included in this PR?
Add supports for
datafusion-physical-plan,datafusion-executionanddatafusion.datafusion-physical-plananddatafusion-executiondoesn't contain any logical changes. It works after I remove some unnecessary feature gates or dependence.Some methods and logic in
datafusionare commented out. The affected file isdatafusion/core/src/datasource/listing/url.rs, all about parsing URL. This is a limitation from our dependenceurl. After some shallow investigates, I guess it's caused byOsStrfrom std isn't available in archwasm-unknown-unknown.Are these changes tested?
Yes
Are there any user-facing changes?
No