Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean internal implementation of WindowUDF #8746

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Conversation

guojidan
Copy link
Contributor

@guojidan guojidan commented Jan 4, 2024

Which issue does this PR close?

Closes #8734 .

Rationale for this change

Clean internal implementation of WindowUDF to use WindowUDFImpl

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions core Core DataFusion crate labels Jan 4, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection @guojidan -- thank you very much for this PR

@alamb alamb merged commit 98f02ff into apache:main Jan 5, 2024
22 checks passed
@guojidan guojidan deleted the udwf branch January 6, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean internal implementation of WindowUDF to use WindowUDFImpl (rather than the function pointers)
2 participants