[MINOR] Remove duplicate test utility and move one utility function for better organization #8652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozankabak
approved these changes
Dec 25, 2023
|
Since this simply removes duplicate code and moves one utility function for better organization I will go ahead and merge this quickly |
ozankabak
changed the title
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Jan 4, 2024
…or better organization (apache#8652) * Code rearrange * Update stream_join_utils.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Make the duplication removed, and seperate the methods for utils.
What changes are included in this PR?
Only code replacements, not new logic are added.
Are these changes tested?
Yes
Are there any user-facing changes?
No