Implement serde for CSV and Parquet FileSinkExec #8646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
andygrove
changed the title
|
@devinjdangelo fyi, this is now ready for review |
andygrove
commented
Dec 29, 2023
| @@ -1220,20 +1222,22 @@ message ParquetWriterOptions { | |||
| } | |||
|
|
|||
| message CsvWriterOptions { | |||
There was a problem hiding this comment.
We have not released a version of DataFusion that contains CsvWriterOptions yet, so it is safe to change the field numbers here.
avantgardnerio
approved these changes
Dec 29, 2023
|
This LGTM @andygrove! I am planning to attempt a more significant refactor in #8667 as discussed with @alamb and might be able to simplify adding support for some of the more advanced file writing options, including externally defined file types is the goal. |
|
Thanks for the reviews @avantgardnerio and @devinjdangelo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8645
Rationale for this change
Needed by Ballista, so that we can support
DataFrame:write_xxxagain.What changes are included in this PR?
Implement serde for CSV and Parquet FileSinkExec, based on existing support for JSON FileSinkExec.
Are these changes tested?
Yes, new tests added.
Are there any user-facing changes?