Add arrow_err! macros, optional backtrace to ArrowError
#8586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
23 tasks
7 tasks
alamb
changed the title
arrow_err! macrosarrow_err! macros, optional backtrace to ArrowError
alamb
approved these changes
Dec 20, 2023
| @@ -802,7 +802,7 @@ impl<'a, S: SimplifyInfo> TreeNodeRewriter for Simplifier<'a, S> { | |||
| && !info.get_data_type(&left)?.is_floating() | |||
| && is_zero(&right) => | |||
| { | |||
| return Err(DataFusionError::ArrowError(ArrowError::DivideByZero)); | |||
| return plan_err!("Divide by zero"); | |||
There was a problem hiding this comment.
Is the idea that since the error wasn't actually generated by Arrow then we shouldn't return an Arrow error?
In theory having a structured ArrowError would be more specific than a general PlanError with a "Divide by zero" message, but I am not sure how much it matters 🤷
There was a problem hiding this comment.
Thanks @alamb for this specific case I have doubled checked before modification but there is no arrow kernel being called directly like in other scenarios when ArrowError is thrown, that was the reason to change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes partially #7360.
Rationale for this change
Continue covering Datafusion Errors with error macros supporting optional backtrace
What changes are included in this PR?
introduced
arrow_err!andarrow_datadusion_err!macros with optional backtrace, to representErr(DatafusionError::ArrowError)andDatafusionError::ArrowError(_)Are these changes tested?
Yes
Are there any user-facing changes?
No