[MINOR]: Generate empty column at placeholder exec #8553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustafasrepo
changed the title
Dandandan
approved these changes
Dec 15, 2023
alamb
approved these changes
Dec 15, 2023
| @@ -75,6 +74,8 @@ impl PlaceholderRowExec { | |||
| ret | |||
| }) | |||
| .collect(), | |||
| // Even if column number is empty we can generate single row. | |||
|
Thanks @mustafasrepo and @Dandandan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Currently, if there is no column at the place holder exec, it generates at least one dummy column. This causes inconsistency in the subsequent schemas for some edge cases. (Where schema of the
PlaceHolderExecitself has 0 columns, but generatedRecordBatchfrom this schema has single column.) Thanks @comphead for bringing this to my attention.What changes are included in this PR?
This PR fixes above mentioned problem.
Are these changes tested?
Yes new test is added. Which is the test in the discussion
Are there any user-facing changes?