-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for DataFrame::write_table #8531
Conversation
.to_str() | ||
.expect("Should be a str") | ||
.to_owned(); | ||
println!("{name}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks @devinjdangelo
Can we add a simpler version to the Datafusion examples? |
I filed #8551 to track this (good idea). Thank you @devinjdangelo and @metesynnada |
Which issue does this PR close?
Closes #8530
Rationale for this change
As pointed out by @comphead, we do not currently have a unit test specific to DataFrame::write_table. This PR adds one.
What changes are included in this PR?
Unit test for DataFrame::write_table method, which is very similar to the unit test for DataFrame::write_parquet.
Are these changes tested?
The change is itself a new test.
Are there any user-facing changes?
No