Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change display of RepartitionExec from SortPreservingRepartitionExec to RepartitionExec preserve_order=true #8521

Merged
merged 5 commits into from
Dec 13, 2023

Conversation

JacobOgle
Copy link
Contributor

@JacobOgle JacobOgle commented Dec 12, 2023

Which issue does this PR close?

#8129

Closes #8129

Rationale for this change

What changes are included in this PR?

This PR changes the display of SortPreservingRepartitionExec to RepartitionExec in code and test cases. In addition, we only display preserve_order when it is true.

Are these changes tested?

Yes, tested according to the contributing guide

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Dec 12, 2023
@JacobOgle
Copy link
Contributor Author

@alamb appreciate the patience for this change request! Let me know if you have any feedback or notice any additional changes that may have been missed. Looking forward to contributing more!

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍 Thanks

@metesynnada metesynnada merged commit 4578f3d into apache:main Dec 13, 2023
22 checks passed
@alamb
Copy link
Contributor

alamb commented Dec 13, 2023

Thank you @JacobOgle and @waynexia and @metesynnada ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change display of RepartitionExec from SortPreservingRepartitionExec to RepartitionExec preserve_order=true`
4 participants