Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: convert marcro list-slice and slice to function #8424

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

Weijun-H
Copy link
Member

@Weijun-H Weijun-H commented Dec 5, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Physical Expressions label Dec 5, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Weijun-H -- this is a nice improvement 👍 I have a suggestion to make things even simpler, but I think this PR could be merged as is too

datafusion/physical-expr/src/array_expressions.rs Outdated Show resolved Hide resolved
@Weijun-H Weijun-H changed the title Minor: convert marcro list-slice to function Minor: convert marcro list-slice and slice to function Dec 5, 2023
@alamb
Copy link
Contributor

alamb commented Dec 6, 2023

Thanks again @Weijun-H

@alamb alamb merged commit 4a46f31 into apache:main Dec 6, 2023
22 of 23 checks passed
appletreeisyellow pushed a commit to appletreeisyellow/datafusion that referenced this pull request Dec 15, 2023
* remove marcro list-slice

* fix cast dyn Array

* remove macro slice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants