Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a summary table to benchmark compare output #8399

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

razeghi71
Copy link
Contributor

Which issue does this PR close?

Closes #8390.

Rationale for this change

Explained in issue.

What changes are included in this PR?

Adding a Benchmark summary at the end of compare table like this:

Comparing main and test
--------------------
Benchmark parquet.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃      main ┃      test ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QSelective-… │ 1297.07ms │ 1246.13ms │     no change │
│ filter:      │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QSelective-… │ 2213.53ms │ 2207.27ms │     no change │
│ filter:      │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QSelective-… │ 2180.89ms │ 2114.42ms │     no change │
│ filter:      │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QNon-select… │ 1669.30ms │ 1631.17ms │     no change │
│ filter:      │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QNon-select… │ 3093.85ms │ 3024.91ms │     no change │
│ filter:      │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QNon-select… │ 3040.35ms │ 2983.02ms │     no change │
│ filter:      │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QBasic       │ 1187.55ms │ 1123.46ms │ +1.06x faster │
│ conjunction: │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QBasic       │  932.60ms │  897.74ms │     no change │
│ conjunction: │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QBasic       │  929.53ms │  865.66ms │ +1.07x faster │
│ conjunction: │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QNested      │ 1242.48ms │ 1188.84ms │     no change │
│ filters:     │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QNested      │ 1339.34ms │ 1309.98ms │     no change │
│ filters:     │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QNested      │ 1301.71ms │ 1265.51ms │     no change │
│ filters:     │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QMany        │ 1518.14ms │ 1511.99ms │     no change │
│ filters:     │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QMany        │ 2496.19ms │ 2502.37ms │     no change │
│ filters:     │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QMany        │ 2482.25ms │ 2524.43ms │     no change │
│ filters:     │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QFilter      │ 1349.09ms │ 1127.22ms │ +1.20x faster │
│ everything:  │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QFilter      │   20.69ms │   21.37ms │     no change │
│ everything:  │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QFilter      │   21.91ms │   21.17ms │     no change │
│ everything:  │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QFilter      │ 1190.26ms │ 1164.32ms │     no change │
│ nothing:     │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QFilter      │ 1137.58ms │ 1099.04ms │     no change │
│ nothing:     │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
│ QFilter      │ 1185.82ms │ 1199.38ms │     no change │
│ nothing:     │           │           │               │
│ pushdown_fi… │           │           │               │
│ reorder_fil… │           │           │               │
│ page_index=… │           │           │               │
└──────────────┴───────────┴───────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary      ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (main)      │ 31830.11ms │
│ Total Time (test)      │ 31029.41ms │
│ Average Time (main)    │  1515.72ms │
│ Average Time (test)    │  1477.59ms │
│ Queries Faster         │          3 │
│ Queries Slower         │          0 │
│ Queries with No Change │         18 │
└────────────────────────┴────────────┘

Are these changes tested?

I didn't add a test as this was UI change, and it didn't have a test before.

Are there any user-facing changes?

The output of the compare command is changed, but I didn't see if it was shown anywhere in the docs.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @razeghi71

@andygrove andygrove merged commit bb2ea4b into apache:main Dec 2, 2023
22 checks passed
@razeghi71 razeghi71 deleted the benchmark-summary branch December 3, 2023 01:55
appletreeisyellow pushed a commit to appletreeisyellow/datafusion that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show total benchmark time in benchmarks output
3 participants